Skip to content

[AIP-94] airflowctl jobs: add check command - #68534

Merged
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:migrate-jobs-check-to-airflowctl
Aug 7, 2026
Merged

[AIP-94] airflowctl jobs: add check command#68534
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:migrate-jobs-check-to-airflowctl

Conversation

@FrankYang0529

@FrankYang0529 FrankYang0529 commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Add a airflowctl jobs check command on top of the existing jobs list operation.
  • Mark airflow jobs check with the maintainer-facing @deprecated_for_airflowctl("airflowctl jobs check") marker and register it in MIGRATED_CLI_COMMANDS.
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code with Opus 4.8] following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@FrankYang0529 FrankYang0529 mentioned this pull request Jun 14, 2026
Open
24 of 41 tasks
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from 232f474 to 0864d30 Compare June 15, 2026 00:41
@FrankYang0529
FrankYang0529 marked this pull request as ready for review June 15, 2026 05:30
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from 0864d30 to b450143 Compare June 15, 2026 10:34
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from b450143 to 0ff6f2b Compare June 15, 2026 11:14
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from 0ff6f2b to e3c0450 Compare July 4, 2026 04:27
@FrankYang0529
FrankYang0529 requested a review from henry3260 as a code owner July 4, 2026 04:27
aaron-y-chen
aaron-y-chen reviewed Jul 8, 2026
View reviewed changes

@aaron-y-chen aaron-y-chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, really nice :)

Comment thread airflow-ctl/src/airflowctl/ctl/commands/jobs_command.py Outdated
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from e3c0450 to 61ad837 Compare July 8, 2026 08:29
Lee-W
Lee-W approved these changes Jul 21, 2026
View reviewed changes

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit. mostly good

Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_jobs_command.py Outdated
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch 2 times, most recently from 244574a to 63b191e Compare July 24, 2026 02:44
Lee-W
Lee-W approved these changes Jul 24, 2026
View reviewed changes

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few parameterization nitpick. but overall looks good

Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_jobs_command.py Outdated
Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_jobs_command.py Outdated
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch 2 times, most recently from 865f1bf to c8fb185 Compare July 31, 2026 03:09
henry3260
henry3260 approved these changes Aug 6, 2026
View reviewed changes

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. It looks good to me!

Comment thread airflow-ctl/src/airflowctl/ctl/commands/jobs_command.py Outdated
@FrankYang0529
[AIP-94] Add airflowctl jobs check command
9ed5b25 
airflowctl had no equivalent of airflow jobs check, so component health
could not be checked through the API from a remote machine. The
validation / alive-count / exit-code logic cannot be auto-generated from
a single operation method, so the command is handwritten on top of the
jobs list operation.

Per the marker-only direction in apache#68402, the airflow CLI counterpart
keeps its local DB implementation (it backs the docker-compose and Helm
liveness probes) and only gets the maintainer-facing migration marker:
no user-facing warning, no behavior change.

Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from c8fb185 to 9ed5b25 Compare August 7, 2026 04:01
@Lee-W
Lee-W merged commit 61f0289 into apache:main Aug 7, 2026
96 checks passed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: airflow-ctl/v0-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ airflow-ctl/v0-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 61f0289 airflow-ctl/v0-1-test

This should apply the commit to the airflow-ctl/v0-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@FrankYang0529
FrankYang0529 deleted the migrate-jobs-check-to-airflowctl branch August 7, 2026 10:08
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
@FrankYang0529 @dabla
[AIP-94] airflowctl jobs: add check command (apache#68534)
9bc5670 
Signed-off-by: PoAn Yang <payang@apache.org>
imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Sep 11, 2026
@FrankYang0529 @imrichardwu
[AIP-94] airflowctl jobs: add check command (apache#68534)
8079654 
Signed-off-by: PoAn Yang <payang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Lee-W approved these changes
@henry3260 henry3260 henry3260 approved these changes
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner
@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner
@dheerajturaga dheerajturaga Awaiting requested review from dheerajturaga dheerajturaga is a code owner
@jedcunningham jedcunningham Awaiting requested review from jedcunningham
@hussein-awala hussein-awala Awaiting requested review from hussein-awala
@jscheffl jscheffl Awaiting requested review from jscheffl
@ashb ashb Awaiting requested review from ashb
@kaxil kaxil Awaiting requested review from kaxil
@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh
+1 more reviewer
@aaron-y-chen aaron-y-chen aaron-y-chen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:airflow-ctl area:CLI backport-to-airflow-ctl/v0-1-test kind:documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FrankYang0529 @Lee-W @aaron-y-chen @henry3260