Repository navigation
Conversation
uranusjr
reviewed
Jul 6, 2026
This comment was marked as spam.
This comment was marked as spam.
anxkhn
force-pushed
the
patch-3
branch
2 times, most recently
from
July 16, 2026 06:04
b40dbbe to
caee4b7
Compare
potiuk
added
the
ready for maintainer review
Contributor
Author
|
@Lee-W the requested deserialization handling has been revised and the checks are green. could you review this when convenient? |
A Dag scheduled with the Task SDK EventsTimetable failed to serialize because the SDK timetable serializer omits the _summary key, while the core EventsTimetable.deserialize required it unconditionally and raised KeyError. Fall back to the summary computed by __init__ when the key is absent, so Dags using the SDK timetable serialize and schedule again while existing serialized data keeps its stored summary. Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
Contributor
Author
|
@uranusjr, could you review this PR again? It has been open for 75 days and is freshly rebased with the requested change applied. Drafted-by: OpenCode (GPT-5.6) (no human review before posting) |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any Dag scheduled with the Task SDK
EventsTimetable(
from airflow.sdk import EventsTimetable) currently fails to serialize withSerializationError: Failed to serialize DAG '...': '_summary', so the Dagcannot be parsed or scheduled.
The SDK timetable serializer in
airflow-core/src/airflow/serialization/encoders.pyemits only
{event_dates, restrict_to_events, description}and omits the_summarykey, but the coreEventsTimetable.deserializeinairflow-core/src/airflow/timetables/events.pyreaddata["_summary"]unconditionally and raised
KeyErrorwhen it was absent. The two areasymmetric:
_summarybecame a required serialized field in #51203, and theSDK serializer that omits it was added in #58669.
This makes
deserializeretain the summary already computed byEventsTimetable.__init__when_summaryis absent. Dags using the SDKtimetable serialize and schedule again, while existing serialized data that
still carries
_summarykeeps its stored value. The deserialize-side fix alsorecovers serialized Dag rows already written without
_summary.A parametrized regression test round-trips a Dag scheduled with the SDK
EventsTimetablethroughDagSerializationwith and without a descriptionand asserts the summary is preserved.
Was generative AI tooling used to co-author this PR?
Generated-by: OpenCode (GPT-5.6) following the guidelines