Repository navigation
Clean up legacy SQLAlchemy references and update remaining doc links - #69535
vishalmore90 wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
|
@vincbeck The SQLAlchemy 2.0 documentation (en/20) still hosts the SQLAlchemy 1.4 changelogs at /en/20/changelog/changelog_14.html. |
6574269 to
aabb80c
Compare
aabb80c to
6d1e79d
Compare
|
Static checks are failing |
Signed-off-by: vishal <httpsvishal07@gmail.com>
6d1e79d to
27595f6
Compare
bugraoz93
left a comment
There was a problem hiding this comment.
Overall looks good, I have comment on prek hook definition. PR is blocked because of log files pushed to PR, that is the breaking part we should address
| - id: lint-json-schema | ||
| name: Lint config_templates/config.yml | ||
| entry: ../scripts/ci/prek/lint_json_schema.py | ||
| entry: python ../scripts/ci/prek/lint_json_schema.py |
There was a problem hiding this comment.
Why we need Python here as Python defined as language. Do we have exception for this hook not working without it similar to others?
| - id: lint-json-schema | ||
| name: Lint chart/values.schema.json | ||
| entry: ../scripts/ci/prek/lint_json_schema.py | ||
| entry: python ../scripts/ci/prek/lint_json_schema.py |
There was a problem hiding this comment.
Same here and I think for all hooks :)
| @@ -0,0 +1,445 @@ | |||
| 2026-07-08T15:21:03.720432Z DEBUG prek: 0.4.8 (cccc61bef 2026-07-04) | |||
| @@ -0,0 +1,493 @@ | |||
| 2026-07-08T15:24:26.106059Z DEBUG prek: 0.4.8 (cccc61bef 2026-07-04) | |||
There was a problem hiding this comment.
This as well please. Not a good practice to push the logs maybe snippets in PR description would be good if these wanted to be shared
|
Context
PR #69200 updated several SQLAlchemy documentation links from
en/14(SQLAlchemy 1.4) toen/20(SQLAlchemy 2.0), reflecting that Airflow core now requires SQLAlchemy 2.0+.However, that PR:
config.yml.set-up-database.rst(where thepostgres://scheme deprecation was introduced) to point to theen/20docs.This PR addresses these omissions and the feedback from issue #69164.
Verification
breeze build-docs(Docker environment not available locally, but the syntax, links, and anchors have been manually verified to resolve correctly).https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170bhttps://docs.sqlalchemy.org/en/20/core/pooling.html#disconnect-handling-pessimisticChecklist