Skip to content

Clean up legacy SQLAlchemy references and update remaining doc links - #69535

Closed
vishalmore90 wants to merge 1 commit into
apache:mainfrom
vishalmore90:fix-issue-69164
Closed

vishalmore90 wants to merge 1 commit into
apache:mainfrom
vishalmore90:fix-issue-69164

Conversation

@vishalmore90

Copy link
Copy Markdown

Context

PR #69200 updated several SQLAlchemy documentation links from en/14 (SQLAlchemy 1.4) to en/20 (SQLAlchemy 2.0), reflecting that Airflow core now requires SQLAlchemy 2.0+.
However, that PR:

  1. Missed updating the pooling documentation link in config.yml.
  2. Incorrectly updated a historical 1.4 changelog link in set-up-database.rst (where the postgres:// scheme deprecation was introduced) to point to the en/20 docs.
  3. Left behind outdated warning prose referring to "SQLAlchemy 1.4+" in the database setup guide, which is no longer relevant now that Airflow 3 requires SQLAlchemy 2.0+ exclusively.

This PR addresses these omissions and the feedback from issue #69164.

Verification

  • Run breeze build-docs (Docker environment not available locally, but the syntax, links, and anchors have been manually verified to resolve correctly).
  • Verified target URLs:
    • Reverted link: https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b
    • Updated link: https://docs.sqlalchemy.org/en/20/core/pooling.html#disconnect-handling-pessimistic

Checklist

@boring-cyborg

boring-cyborg Bot commented Jul 7, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Comment thread airflow-core/docs/howto/set-up-database.rst Outdated
@vishalmore90

Copy link
Copy Markdown
Author

@vincbeck The SQLAlchemy 2.0 documentation (en/20) still hosts the SQLAlchemy 1.4 changelogs at /en/20/changelog/changelog_14.html.
Since Airflow core now exclusively requires SQLAlchemy 2.0+, it preferred to point all documentation links to the /en/20/ namespace so that users remain within the modern documentation layout and navigation context. I will revert this link to en/20.

@vishalmore90 vishalmore90 changed the title docs: Clean up SQLAlchemy 1.4 legacy references and update remaining … Clean up legacy SQLAlchemy references and update remaining doc links Jul 7, 2026
@vishalmore90
vishalmore90 requested a review from vincbeck July 7, 2026 16:49
@vincbeck

vincbeck commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Static checks are failing

Signed-off-by: vishal <httpsvishal07@gmail.com>

@bugraoz93 bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I have comment on prek hook definition. PR is blocked because of log files pushed to PR, that is the breaking part we should address

- id: lint-json-schema
name: Lint config_templates/config.yml
entry: ../scripts/ci/prek/lint_json_schema.py
entry: python ../scripts/ci/prek/lint_json_schema.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need Python here as Python defined as language. Do we have exception for this hook not working without it similar to others?

- id: lint-json-schema
name: Lint chart/values.schema.json
entry: ../scripts/ci/prek/lint_json_schema.py
entry: python ../scripts/ci/prek/lint_json_schema.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and I think for all hooks :)

Comment thread log2.txt
@@ -0,0 +1,445 @@
2026-07-08T15:21:03.720432Z DEBUG prek: 0.4.8 (cccc61bef 2026-07-04)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be deleted

Comment thread log3.txt
@@ -0,0 +1,493 @@
2026-07-08T15:24:26.106059Z DEBUG prek: 0.4.8 (cccc61bef 2026-07-04)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as well please. Not a good practice to push the logs maybe snippets in PR description would be good if these wanted to be shared

@vishalmore90

Copy link
Copy Markdown
Author

Static checks are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SQLAlchemy documentation links from 1.4 (en/14) to 2.0 (en/20)

3 participants