Repository navigation
Fix remaining SQLAlchemy 1.4/2.1 doc references and fact-check migration - #69793
Draft
joshuabvarghese wants to merge 1 commit into
Draft
joshuabvarghese wants to merge 1 commit into
joshuabvarghese wants to merge 1 commit into
Conversation
joshuabvarghese
marked this pull request as ready for review
July 13, 2026 11:29
potiuk
marked this pull request as draft
July 28, 2026 16:10
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #69164
(follow-up to #69203 )
What this does
#69200 already fixed most of the 1.4→2.0 doc links. This PR:
en/14link (config.yml,sql_alchemy_pool_pre_ping)en/21(beta) link that wasn't in the original 9 but hasthe same root problem — airflow-core requires
sqlalchemy>=2.0.48, not 2.1Verification table
config.yml:686test_orm_event_handlers.py:20utils/db.py:93-94sqlalchemy.orm.MappedClassProtocol__table__/__mapper__/__call__; ours checks__tablename__. They're not interchangeable — the TODO was wrong, not just outdatedDeliberately NOT changed
set-up-database.rst:201— correctly stays onen/20/changelog/changelog_14.htmleventhough it documents 1.4-era behavior, because SQLAlchemy hosts historical changelogs
under the current docs version's URL tree.
settings.pyalready relies on this samepattern independently, which cross-confirms it's correct.
configuration.py, provider changelogs,and
RELEASE_NOTES.rst— true historical statements, not stale references.Testing
pre-commit run --files airflow-core/src/airflow/config_templates/config.yml airflow-core/src/airflow/utils/db.py airflow-core/tests/unit/utils/test_orm_event_handlers.py— all content-inspecting hooks pass (ruff, mypy, yamllint, license headers, codespell, newsfragment check)Important
🛠️ Maintainer triage note for @joshuabvarghese · by
@potiuk· 2026-07-28 16:10 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
See the Pull Request quality criteria for how to fix each item. There is no rush.
Note: your branch is 362 commits behind
main— please rebase and push again to get up-to-date CI results.Automated triage — may be imperfect; a maintainer takes the next look. We use this two-stage triage process so maintainers' limited time goes to the conversation with you.