Skip to content

Keep Go SDK variable lookups consistent - #69899

Closed
shaealh wants to merge 1 commit into
apache:mainfrom
shaealh:shaealh/airflow-67598-share-variable-env-helper
Closed

shaealh wants to merge 1 commit into
apache:mainfrom
shaealh:shaealh/airflow-67598-share-variable-env-helper

Conversation

@shaealh

@shaealh shaealh commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Share the AIRFLOW_VAR_* environment-override lookup through the exported sdk.VariableFromEnv helper.

Use the shared helper from both the HTTP-backed and coordinator clients so the env-first precedence has one canonical implementation. This also removes the duplicated coordinator lookup and its associated TODO.

closes: #67598

Testing

  • go test ./...
  • go vet ./...
  • go mod tidy
  • Airflow prek hooks

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, as #71874 was merged (since there is coordinator client only). We don't need this PR any more. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share AIRFLOW_VAR_* env-override helper between HTTP and coordinator Go SDK clients

2 participants