Repository navigation
Conversation
viiccwen
force-pushed
the
fix-go-sdk-start-task-token-logging
branch
from
July 16, 2026 12:17
3dc02af to
e6ce608
Compare
jason810496
reviewed
Jul 18, 2026
uranusjr
reviewed
Jul 18, 2026
uranusjr
reviewed
Jul 18, 2026
Task logs can be available to readers who should not receive task-scoped API credentials. A start-task API failure must not widen access to the bearer token carried by the request. Signed-off-by: viiccwen <vicwen@apache.org>
viiccwen
force-pushed
the
fix-go-sdk-start-task-token-logging
branch
from
July 20, 2026 08:11
e6ce608 to
697a425
Compare
Contributor
Author
|
Hello @jason810496 @uranusjr, politely tag for further review. |
jason810496
reviewed
Aug 20, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Sorry, as #71874 was merged. We don't need this PR any more. Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Go SDK worker received an HTTP error while starting a task, it logged the complete request headers. Because the API client carries the task-scoped bearer token in the
Authorizationheader, the token was included in the task error log.Limit the logged request details to an explicit allowlist containing the request path, method, and correlation ID. This preserves useful diagnostics without including request credentials, query parameters, or other headers.
The regression test sends a real HTTP request containing a bearer token to a test server, returns an HTTP 400 response, and verifies both that the request carried the token and that the resulting structured log contains neither the token nor the
Authorizationheader.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.