Repository navigation
UI: Preserve Dag tab when switching Dags - #70699
Merged
Merged
Conversation
Keep users in the same Dag context while comparing Dags, without carrying entity-specific routes that may not exist on the destination Dag.
shivaam
marked this pull request as ready for review
July 29, 2026 19:53
shivaam
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 29, 2026 19:53
Member
|
Could you add before/after screenshots? It would help reviewers better understand the changes. |
Contributor
Author
The change is just in the URL. I am not sure if a screenshot will help here as it is navigation change. I can probable add a video or something |
Contributor
Author
|
Added a screenshot. |
bbovenzi
reviewed
Aug 6, 2026
Path parsing made unrelated and entity-specific pages difficult to distinguish reliably. Route-owned metadata keeps tab preservation aligned with the router's actual matches.
bbovenzi
reviewed
Aug 11, 2026
bbovenzi
reviewed
Aug 18, 2026
Keep route metadata selection independent from the application router so navigation modules do not depend on each other.
bbovenzi
approved these changes
Aug 21, 2026
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
* UI: Preserve Dag tab when switching Dags Keep users in the same Dag context while comparing Dags, without carrying entity-specific routes that may not exist on the destination Dag. * UI: Use route metadata when switching Dags Path parsing made unrelated and entity-specific pages difficult to distinguish reliably. Route-owned metadata keeps tab preservation aligned with the router's actual matches. * UI: Derive preserved tabs from route handles * UI: Reset plugin routes when switching Dags * UI: Type tab route handles * UI: Break Dag tab routing import cycle Keep route metadata selection independent from the application router so navigation modules do not depend on each other. --------- Co-authored-by: Shivam <shivam@Shivams-Mac-mini.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #57625
What changed
When selecting another DAG from the DAG search dialog, preserve the current DAG-level tab when the destination supports it.
Backfills need a separate guard because tab availability is DAG-specific. A backfillable source DAG can expose
/backfills, while the selected destination DAG may reportis_backfillable = false.airflow-70699-cinematic-framed-demo.mp4
Testing
Screenshots
Before/after screenshots will be attached to this draft.
Was generative AI tooling used to co-author this PR?
Generated-by: Codex following the guidelines