Skip to content

Task SDK: Skip POSIX-only supervisor and task runner tests on Windows - #70946

Open
Adityakk9031 wants to merge 1 commit into
apache:mainfrom
Adityakk9031:windows-compat-fixes
Open

Adityakk9031 wants to merge 1 commit into
apache:mainfrom
Adityakk9031:windows-compat-fixes

Conversation

@Adityakk9031

@Adityakk9031 Adityakk9031 commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Skip POSIX-only supervisor and task runner tests on Windows using pytestmark rather than stubbing out POSIX syscalls. CI on Linux runs all tests as normal.

Per maintainer request (@potiuk), the Windows compatibility changes have been split into separate, focused PRs:

Related to #69464 (not closing it).

@Adityakk9031

Copy link
Copy Markdown
Contributor Author

@potiuk have a look

@potiuk

potiuk commented Aug 13, 2026

Copy link
Copy Markdown
Member

Please split those even further - each for different area. Some of them some prek, some tests, some production.

Comment thread scripts/ci/prek/common_prek_utils.py

@uros-b uros-b left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adityakk9031 Please fix the PR title, otherwise code changes look good!

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because the author has not responded to a request for more information. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 24, 2026
@Adityakk9031 Adityakk9031 changed the title Fix Windows compatibility in prek scripts and POSIX-only test skip gu… Fix Windows compatibility in prek scripts and guard POSIX-only calls Sep 24, 2026
@Adityakk9031

Copy link
Copy Markdown
Contributor Author

@uros-b changed please merge it

@uros-b

uros-b commented Sep 24, 2026

Copy link
Copy Markdown
Member

Thank you @Adityakk9031, please ping @potiuk here for further review

@Adityakk9031 Adityakk9031 changed the title Fix Windows compatibility in prek scripts and guard POSIX-only calls Task SDK: Skip POSIX-only supervisor and task runner tests on Windows Sep 24, 2026
@Adityakk9031

Copy link
Copy Markdown
Contributor Author

@potiuk @uros-b Per feedback, I have split the changes into focused micro-PRs by area:

@github-actions github-actions Bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 25, 2026

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this up. The scope is right now: only the test skips, with the prek and shared/stats parts in their own PRs. The skips themselves need to be narrower:

  1. test_task_runner.py: the module-wide skip hides about 187 tests, but task_runner.py uses no POSIX-only process primitives that I can find. It only installs a SIGTERM handler, which exists on Windows, and timeout.py already falls back when SIGALRM is missing. Could you share which tests actually fail on Windows (a pytest summary with the errors), and mark only those, with a reason that names the API involved?
  2. test_supervisor.py already uses precise per-test markers (around lines 5145–5246, and the win32 skip at 5412). Please follow that pattern: mark the classes or tests that spawn processes (os.fork / posix_spawn / setpgid / killpg) rather than the whole module, so tests that don't need POSIX keep running.
  3. The description says "Close: #69464", but that issue is the Sentry before_send bug and unrelated to this change. Please remove or fix the reference so merging doesn't close it.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@kaxil

kaxil commented Oct 20, 2026

Copy link
Copy Markdown
Member

@Adityakk9031 I don't think we say anywhere that Airflow support Windows!

If your goal is to ensure it runs with Windows, please upload a demo window or screenshot of it working end to end

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants