Repository navigation
Conversation
Execution API task tokens identify a single task instance, but XCom writes previously trusted the URL coordinates independently. A valid task token could therefore write under another task instance identity within its allowed team boundary.
8df52f7 to
e41f050
Compare
|
Hello @shivaam - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 6 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Execution API JWTs identify a single task instance, but the existing XCom POST route also accepts the Dag, run, task, and map identity in the URL and query parameters. Previously, a valid task token could supply different coordinates and write an XCom under another task instance identity within its permitted team boundary.
This change keeps the existing route for Task SDK and API server compatibility while making the JWT-resolved task instance authoritative for writes. The endpoint rejects a missing token task instance or any Dag, run, task, or map-index mismatch with a structured
403response, and uses the resolved identity for bothXComModelandTaskMapwrites.The in-process Execution API used by local task supervisors has no worker JWT. It overrides the write-identity dependency and resolves the task instance from the trusted route coordinates, preserving
dag.test()and related in-process XCom behavior for both mapped and unmapped tasks.This is intentionally the smallest compatible first slice of #70080. XCom reads retain explicit source identifiers because cross-task, cross-Dag, historical, and mapped pulls need to address task instances other than the authenticated caller. Removing identifiers from the write URL can follow through an API-versioned endpoint once mixed Task SDK/API server compatibility is designed.
Related: #70080
Testing
prek run ruff --from-ref upstream/main --to-ref HEADprek run ruff-format --from-ref upstream/main --to-ref HEADproviders/common/sqlmypy stub error on currentmain.201; cross-task, cross-run, map-index mismatch, and missing-task-instance writes returned structured403 access_deniedresponses; PostgreSQL contained no forbidden XCom rows.Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines