Repository navigation
Add Redis cluster mode support to RedisHook - #71067
Merged
Merged
Conversation
FrankYang0529
marked this pull request as ready for review
August 4, 2026 10:28
FrankYang0529
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
August 4, 2026 10:28
Miretpl
requested changes
Aug 16, 2026
Contributor
|
Could you also adjust the PR description in terms of why it is needed? Currently, we only know the difference between standalone Redis and cluster deployment and how it handles connections. |
FrankYang0529
force-pushed
the
airflow-10504-redis-cluster
branch
from
August 17, 2026 12:43
e4d7b23 to
254fa27
Compare
Member
Author
|
@Miretpl Thanks for the review. I addressed all comments and updated PR description. |
Miretpl
requested changes
Aug 17, 2026
FrankYang0529
force-pushed
the
airflow-10504-redis-cluster
branch
from
August 18, 2026 01:18
254fa27 to
07e0ecd
Compare
FrankYang0529
force-pushed
the
airflow-10504-redis-cluster
branch
from
August 24, 2026 08:29
07e0ecd to
e500dca
Compare
Miretpl
requested changes
Aug 25, 2026
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
Just small nit about exception messages and LGTM.
FrankYang0529
force-pushed
the
airflow-10504-redis-cluster
branch
2 times, most recently
from
August 26, 2026 08:22
6680260 to
82a4445
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-10504-redis-cluster
branch
from
August 26, 2026 14:24
82a4445 to
3898c37
Compare
Miretpl
approved these changes
Aug 26, 2026
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
Signed-off-by: PoAn Yang <payang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MOVEDinstead of serving it.RedisHookonly built a standaloneredis.Redisclient, which does not follow those redirects. So every key-based operation in this provider can fail, depending on where the key happens to hash.RedisTaskHandler(remote logging) —lrangeto read,rpush/ltrim/expireto write. Its key is derived from dag id, run id and task id, so each task instance's log targets a different node.RedisKeySensorusesexiststo watch key. The key can be dynamic string, so it can be on different nodes.How
clusterconnection extra. When set,get_conn()builds aredis.cluster.RedisCluster, which followsMOVED/ASKredirects.startup_nodesextra to supply extra bootstrap nodes.Verification
uv run --project providers/redis pytest providers/redis/tests/unit/redis/hooks/test_redis.py -xvsbreeze testing providers-integration-tests --db-reset --integration redisWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.