Repository navigation
Java SDK: Declare a Dag's task graph with @Builder.Deps - #71189
Merged
jason810496 merged 13 commits intoOct 6, 2026
Merged
Conversation
This was referenced Aug 5, 2026
phanikumv
reviewed
Aug 5, 2026
phanikumv
left a comment
Contributor
There was a problem hiding this comment.
this PR seems way too huge, is there a way to create smaller PRs so that it is easier to review?
Member
Author
jason810496
force-pushed
the
feature/java-sdk-native-dag
branch
3 times, most recently
from
August 14, 2026 06:44
22dca7c to
c698338
Compare
jason810496
force-pushed
the
feature/java-sdk-native-dag
branch
from
August 21, 2026 07:30
c698338 to
68fd401
Compare
1 task done
jason810496
force-pushed
the
feature/java-sdk-native-dag
branch
6 times, most recently
from
September 21, 2026 08:37
6d1d542 to
a6f69ba
Compare
FrankYang0529
left a comment
Member
There was a problem hiding this comment.
Overall LGTM. Leave one question.
jason810496
commented
Oct 5, 2026
jason810496
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for the review.
jason810496
requested review from
ashb,
gopidesupavan and
potiuk
as code owners
October 5, 2026 11:06
henry3260
reviewed
Oct 5, 2026
1 task done
Open
1 task done
henry3260
approved these changes
Oct 5, 2026
henry3260
left a comment
Contributor
There was a problem hiding this comment.
Nice just one nit found by claude
RESERVED_VIEW_NAMES includes notify, which the ADR's own example uses: @Builder.Task(id = "notify") public void notify(Client client) at ADR-0002 lines 67-68. The view strips the Client parameter, so it would generate default TaskRef notify(), which cannot override Object.notify(). Rejecting it is right, but the ADR example needs renaming, it appears at lines 67, 80, 104, 132 and 135.
FrankYang0529
approved these changes
Oct 5, 2026
guan404ming
approved these changes
Oct 5, 2026
jason810496
commented
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Support the TaskFlow syntax to define the graph for native Dag with annotation syntax, follow the user interface design in ADR-0002.
Example
The processor generates the interface that wiring class implements:
How
long extract(Client)while the view holdsTaskRef<Long> extract()— two methods that would clash in one class. The wiring class implements the view, so the Dag class keeps its inheritance slot and, beingstatic, cannot reach the real task methods.depends()runs once at registration with the Dag in scope. Nothing reads a syntax tree, so this works under any compiler rather than only javac.@Builder.Taskmethod must be called in the wiring class; a task the wiring missed fails at Dag-parse time.Bundle.register(Class)now also accepts a@Builder.Dagclass and registers the Dag its generated builder builds..config(...)assertion ingenerateBuilderLowersConfigAttributesmoves from the builder golden into the wiring-view golden, because that is where theTaskDefis now constructed. It is relocated coverage, not lost coverage.Was generative AI tooling used to co-author this PR?