Repository navigation
Fix Asset Event table titles showing a raw translation key - #71443
Merged
bbovenzi merged 1 commit intoAug 12, 2026
Merged
Conversation
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 11, 2026 15:50
boring-cyborg
Bot
added
area:translations
area:UI
pierrejeambrun
force-pushed
the
fix-asset-event-source-translation
branch
from
August 11, 2026 16:03
492c8a8 to
2027bc7
Compare
Member
Author
Before
After
|
Contributor
|
Nesting i18n keys is something we do want to do to make our translation strings more reusable. I would prefer that we actually fix nesting so that it does work for english and every other language. |
Member
Author
|
I can make nesting work for en. And leave the other owners do the work for theirs translation, I'm not confident changing blindly 20 locals I cannot double check. Also we probably want to adjust the i18n scripts to detect translation keys that are using nesting in |
The English assetEvent/sourceAssetEvent/createdAssetEvent title keys reference their
labels through nested $t() (from the translation DRY refactor). These keys are
consumed by the shared Asset Events table, whose translation hook defaults to the
dashboard namespace, so an unqualified nested $t() resolved against dashboard —
where the referenced keys do not exist — and the titles rendered raw keys ("Source
assetEvent_other", "asset_one Events"). Qualifying the nested references with the
common namespace keeps the DRY nesting and resolves it regardless of the consuming
component's default namespace.
pierrejeambrun
marked this pull request as draft
August 11, 2026 16:13
pierrejeambrun
force-pushed
the
fix-asset-event-source-translation
branch
from
August 11, 2026 16:13
2027bc7 to
3bca94b
Compare
Contributor
|
Ok, let's fix english and handle the other languages in another PR |
Member
Author
Done |
pierrejeambrun
marked this pull request as ready for review
August 12, 2026 09:05
bbovenzi
approved these changes
Aug 12, 2026
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Aug 14, 2026
) The English assetEvent/sourceAssetEvent/createdAssetEvent title keys reference their labels through nested $t() (from the translation DRY refactor). These keys are consumed by the shared Asset Events table, whose translation hook defaults to the dashboard namespace, so an unqualified nested $t() resolved against dashboard — where the referenced keys do not exist — and the titles rendered raw keys ("Source assetEvent_other", "asset_one Events"). Qualifying the nested references with the common namespace keeps the DRY nesting and resolves it regardless of the consuming component's default namespace.
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
) The English assetEvent/sourceAssetEvent/createdAssetEvent title keys reference their labels through nested $t() (from the translation DRY refactor). These keys are consumed by the shared Asset Events table, whose translation hook defaults to the dashboard namespace, so an unqualified nested $t() resolved against dashboard — where the referenced keys do not exist — and the titles rendered raw keys ("Source assetEvent_other", "asset_one Events"). Qualifying the nested references with the common namespace keeps the DRY nesting and resolves it regardless of the consuming component's default namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset Events tables render their titles as raw i18n keys instead of readable text:
The shared Asset Events table (
components/Assets/AssetEvents.tsx) resolves these titles withuseTranslation(["dashboard", "common", "dag"]), whose default namespace isdashboard. Inen/common.jsonthese keys reference their labels through nested$t()(introduced by the translation DRY refactor #68285), e.g."assetEvent_other": "$t(asset_one) Events"and"sourceAssetEvent_other": "Source $t(assetEvent_other)". An unqualified nested$t(...)resolves against the consuming hook's default namespace (dashboard), where those keys don't exist, so the title falls back to the raw key.This keeps the DRY nesting and fixes it by qualifying the nested references with the
commonnamespace ($t(common:asset_one),$t(common:assetEvent_other), …), so they resolve incommonregardless of the consuming component's default namespace.Verified with i18next directly: all three keys now render "Asset Event(s)" / "Source Asset Event(s)" / "Created Asset Event(s)" for every count, both in the
dashboard-default context and with the full namespace array.Note: only
enuses the nested form; the other locales currently duplicate the strings inline. Migrating them to the same nested/DRY structure is separate follow-up work.related: #68285
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines