Repository navigation
Allow OpensearchTaskHandler and OpensearchRemoteLogIO to take empty username and password - #71692
Merged
eladkal merged 8 commits intoOct 4, 2026
Conversation
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
from
August 18, 2026 21:57
a7d1457 to
5ae8aa0
Compare
Owen-CH-Leung
suggested changes
Aug 21, 2026
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
from
August 21, 2026 21:16
5ae8aa0 to
0887e75
Compare
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
from
August 21, 2026 21:39
344b59e to
5be6917
Compare
Owen-CH-Leung
suggested changes
Aug 22, 2026
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
from
August 22, 2026 12:50
5be6917 to
709b9c0
Compare
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
2 times, most recently
from
August 23, 2026 18:06
0f48dd7 to
174bc2a
Compare
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
from
August 26, 2026 19:17
174bc2a to
2e92441
Compare
topherinternational
force-pushed
the
os-task-handler-no-auth-client
branch
from
September 4, 2026 11:24
2e92441 to
25cb666
Compare
Contributor
Author
|
@jason810496 is there anything blocking this from merging? |
…sername and password
…or password are non-empty
eladkal
force-pushed
the
os-task-handler-no-auth-client
branch
from
October 4, 2026 08:21
25cb666 to
c0510ad
Compare
eladkal
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows
OpensearchTaskHandlerandOpensearchRemoteLogIOto utilize Opensearch connections without user/password authentication.Current Behavior
These classes pass their
usernameandpasswordattributes to theOpenSearchclient constructor. In the event these attributes are empty or null, the client attempts to connect to the host using an auth string of":"or"None:None".Proposed Behavior
os_task_handler._create_opensearch_client()passes thehttp_authtuple to theOpenSearch()client constructor only if bothusernameandpasswordare truthy (i.e., they are non-empty strings).Rationale
Several use cases take advantage of a non-authenticated endpoint. Opensearch instances are sometimes deployed without authentication for testing purposes, and production instances can be operated inside of a VPC where networking rules rather than credentials control access from other services in the cluster.
Additionally, this non-authenticated capability is already in place in the
OpenSearchHook.Was generative AI tooling used to co-author this PR?