Repository navigation
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Miretpl
left a comment
There was a problem hiding this comment.
Could you change a branch from main to chart/v1-2x-test? GitSync will be dropped with Helm Chart 2.0 (current main branch).
4b0dc1f to
0835c23
Compare
|
Thanks for pointing this out. I rebased the single change onto Drafted-by: Codex (GPT-5); reviewed by @LE0-Lin before posting |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
The Helm chart supports both a named
dags.gitSync.sshKeySecretand an inlinedags.gitSync.sshKeyfor SSH authentication. However, the post-install notes only warned about missingknownHostsconfiguration for the named-secret path, so inline-key users could miss the same host-verification warning.Include both SSH key sources in the warning condition while continuing to suppress the warning when
knownHostsis configured.Testing
breeze testing helm-tests --test-type airflow_aux -- -q(665 passed)prek run --files chart/templates/NOTES.txt --stage pre-commithelm lint chartwith Helm 3.19Was generative AI tooling used to co-author this PR?
Developed and reviewed by @LE0-Lin with assistance from Codex (GPT-5), following the guidelines.