Skip to content

Warn when inline gitSync SSH keys lack known hosts - #71883

Merged
Miretpl merged 1 commit into
apache:chart/v1-2x-testfrom
LE0-Lin:fix/helm-inline-ssh-known-hosts-warning
Sep 2, 2026
Merged

Miretpl merged 1 commit into
apache:chart/v1-2x-testfrom
LE0-Lin:fix/helm-inline-ssh-known-hosts-warning

Conversation

@LE0-Lin

@LE0-Lin LE0-Lin commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

The Helm chart supports both a named dags.gitSync.sshKeySecret and an inline dags.gitSync.sshKey for SSH authentication. However, the post-install notes only warned about missing knownHosts configuration for the named-secret path, so inline-key users could miss the same host-verification warning.

Include both SSH key sources in the warning condition while continuing to suppress the warning when knownHosts is configured.

Testing

  • breeze testing helm-tests --test-type airflow_aux -- -q (665 passed)
  • prek run --files chart/templates/NOTES.txt --stage pre-commit
  • helm lint chart with Helm 3.19
  • Helm 4 client-side dry-run matrix covering inline key, named secret, configured known hosts, and no SSH key

Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-5) was used as an assistant.

Developed and reviewed by @LE0-Lin with assistance from Codex (GPT-5), following the guidelines.

@boring-cyborg

boring-cyborg Bot commented Aug 20, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Miretpl Miretpl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change a branch from main to chart/v1-2x-test? GitSync will be dropped with Helm Chart 2.0 (current main branch).

@Miretpl Miretpl added this to the Airflow Helm Chart 1.23.0 milestone Aug 25, 2026
@LE0-Lin
LE0-Lin force-pushed the fix/helm-inline-ssh-known-hosts-warning branch from 4b0dc1f to 0835c23 Compare August 26, 2026 01:36
@LE0-Lin
LE0-Lin changed the base branch from main to chart/v1-2x-test August 26, 2026 01:36
@LE0-Lin

LE0-Lin commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks for pointing this out. I rebased the single change onto chart/v1-2x-test and updated the PR base accordingly. The resulting diff is still limited to chart/templates/NOTES.txt, and helm lint chart passes with Helm 3.19.


Drafted-by: Codex (GPT-5); reviewed by @LE0-Lin before posting

@Miretpl
Miretpl merged commit b297982 into apache:chart/v1-2x-test Sep 2, 2026
2 checks passed
@boring-cyborg

boring-cyborg Bot commented Sep 2, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants