Repository navigation
Prevent React plugins from inheriting a prior bundle's component - #71943
Merged
pierrejeambrun merged 1 commit intoAug 21, 2026
Merged
Conversation
pierrejeambrun
force-pushed
the
fix-react-plugin-stale-global
branch
from
August 21, 2026 12:36
bc7dcca to
5338e26
Compare
pierrejeambrun
marked this pull request as ready for review
August 21, 2026 13:55
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 21, 2026 13:55
pierrejeambrun
force-pushed
the
fix-react-plugin-stale-global
branch
from
August 21, 2026 14:04
5338e26 to
b362853
Compare
A React plugin bundle exports its component by assigning to the shared globalThis.AirflowPlugin as a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left there, so one plugin silently rendered another plugin's component instead of failing. Clear the shared global before each import so a bundle that assigns nothing surfaces a clear error rather than inheriting a stale component.
pierrejeambrun
force-pushed
the
fix-react-plugin-stale-global
branch
from
August 21, 2026 14:12
b362853 to
09f7f8d
Compare
bbovenzi
approved these changes
Aug 21, 2026
Contributor
|
Good catch! |
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker bdf3ee5 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
1 task done
pierrejeambrun
added a commit
that referenced
this pull request
Aug 27, 2026
) (#72136) A React plugin bundle exports its component by assigning to the shared globalThis.AirflowPlugin as a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left there, so one plugin silently rendered another plugin's component instead of failing. Clear the shared global before each import so a bundle that assigns nothing surfaces a clear error rather than inheriting a stale component. (cherry picked from commit bdf3ee5)
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
) (#72136) A React plugin bundle exports its component by assigning to the shared globalThis.AirflowPlugin as a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left there, so one plugin silently rendered another plugin's component instead of failing. Clear the shared global before each import so a bundle that assigns nothing surfaces a clear error rather than inheriting a stale component. (cherry picked from commit bdf3ee5)
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…che#71943) A React plugin bundle exports its component by assigning to the shared globalThis.AirflowPlugin as a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left there, so one plugin silently rendered another plugin's component instead of failing. Clear the shared global before each import so a bundle that assigns nothing surfaces a clear error rather than inheriting a stale component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A React plugin bundle exports its component by assigning to the shared
globalThis.AirflowPluginas a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left onglobalThis.AirflowPlugin— so one plugin silently rendered another plugin's component instead of failing. Thetypeof !== "function"guard didn't catch it because the stale value is a valid function.This clears the shared global before each import, so a bundle that assigns nothing surfaces a clear error (and the error page) rather than inheriting a stale component. The resolved component is also cached under its plugin name only after validation, so a failed load never leaves a bad value behind.
Before
Plugin A
After
Plugin A
closes: #56169
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines