Repository navigation
Add embedding kwargs to common AI hooks and operators - #72002
Merged
Merged
Conversation
jeff3071
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
August 23, 2026 08:32
kaxil
approved these changes
Aug 25, 2026
jeff3071
force-pushed
the
add-embedding-kwargs-to-common-ai
branch
from
August 25, 2026 05:18
38174a3 to
e121620
Compare
Lee-W
reviewed
Aug 25, 2026
Lee-W
reviewed
Aug 27, 2026
Lee-W
left a comment
Member
There was a problem hiding this comment.
mostly good. one remaining nitpick
kaxil
reviewed
Sep 9, 2026
kaxil
reviewed
Sep 10, 2026
kaxil
reviewed
Sep 12, 2026
kaxil
reviewed
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Embedding model options such as custom dimensions cannot currently be configured in common AI hooks and operators.
Following the OpenAI provider design, these options are passed explicitly instead of through connection
extra.What
embedding_kwargsto LangChain and LlamaIndex hooks.Test
Use testing dag below and self-host embedding model.
vllm command
Was generative AI tooling used to co-author this PR?
Generated-by: (Codex:GPT-5.6-sol) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.