Repository navigation
use secrets for fab users --use-random-password generation - #72092
Merged
Merged
Conversation
random.choices draws from the Mersenne Twister PRNG that Python documents as unfit for security use, so the generated web-login credential is predictable, and string.printable also seeds the value with whitespace and control characters that land in the stored password.
vincbeck
approved these changes
Aug 26, 2026
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…72092) random.choices draws from the Mersenne Twister PRNG that Python documents as unfit for security use, so the generated web-login credential is predictable, and string.printable also seeds the value with whitespace and control characters that land in the stored password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_create_password builds the --use-random-password value with random.choices, the Mersenne Twister PRNG that Python documents as unfit for security use, so the generated web-login credential comes from a reconstructable stream, and string.printable also seeds it with whitespace and control characters that land in the stored password (roughly 63% of generated values). Switch to secrets.choice over the printable non-whitespace alphabet, matching the generation already used in the teradata provider's encryption_utils and the kubernetes and ssh helpers. Added a regression test asserting the CSPRNG is used and that no whitespace reaches the password.
Was generative AI tooling used to co-author this PR?