Repository navigation
Distinguish empty plugin folder from plugin load failures in logs - #72432
Conversation
Empty plugins/ on a new install looked like a failure in the summary line even when nothing was wrong; warn only when imports actually fail.
SameerMesiah97
left a comment
There was a problem hiding this comment.
Approved pending green CI.
|
Thanks Sameer. CI hasn't actually run yet on this one — the Checks tab only shows Mergeable/WIP. The AMD / CodeQL / newsfragment workflows are stuck on If someone with write access can approve and run the workflows on the PR, I can chase any failures from there. Locally the two plugin tests I added passed. |
|
Local run of the two tests this PR adds / extends — both green on my machine: Still waiting on the fork workflow approval before GitHub CI can run the same checks here. |
|
I dont have write access so I cannot approve the CI workflow. You can try posting the link to the PR in the contributors channel in the airflow slack. |
|
Okay @SameerMesiah97, i've posted about it in the #new-contributors slack channel as well, so hopefully someone with write access can hit approve on the CI workflow when they get a moment Thanks :D |
…ache#72432) Empty plugins/ on a new install looked like a failure in the summary line even when nothing was wrong; warn only when imports actually fail.
…ache#72432) Empty plugins/ on a new install looked like a failure in the summary line even when nothing was wrong; warn only when imports actually fail.

closes: #56816
Empty
plugins/on a new install was easy to read as a failure — per-file import errors already log at exception level, but the summary line didn't distinguish "nothing here" from "something broke".Tested locally:
uv run --project airflow-core pytest airflow-core/tests/unit/plugins/test_plugins_manager.py::TestPluginsManager::test_empty_plugins_folder_logs_no_failure airflow-core/tests/unit/plugins/test_plugins_manager.py::TestPluginsManager::test_loads_filesystem_plugins_exception -xvs