Skip to content

Stop emitting the legacy first_task_scheduling_delay metric twice - #72512

Merged
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-dedup-first-task-scheduling-delay-metric
Sep 15, 2026
Merged

Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-dedup-first-task-scheduling-delay-metric

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • DagRun._emit_true_scheduling_delay_stats_for_finished_state() still builds dagrun.<dag_id>.first_task_scheduling_delay instead of leaving it to the stats.timing("dagrun.first_task_scheduling_delay", ...) call on the next line, which already emits that name.

How

  • Delete the stats.timing(f"dagrun.{dag.dag_id}.first_task_scheduling_delay", ...) call and let the registry supply the legacy name.

Verification

  • uv run --frozen --project airflow-core pytest airflow-core/tests/unit/models/test_dagrun.py

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 marked this pull request as ready for review September 4, 2026 11:33
@Lee-W
Lee-W merged commit e86e0e5 into apache:main Sep 15, 2026
150 checks passed
@FrankYang0529
FrankYang0529 deleted the airflow-dedup-first-task-scheduling-delay-metric branch September 16, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants