Repository navigation
Fix branch operators inside mapped task groups not skipping siblings - #72594
Closed
sohailiqrar wants to merge 1 commit into
Closed
sohailiqrar wants to merge 1 commit into
sohailiqrar wants to merge 1 commit into
Conversation
When a @task.branch lives inside a mapped @task_group it is not itself expanded (parent.is_mapped is False), but its TI runs at the group's map_index and SkipMixin writes the skip XCom there — not at -1. NotPreviouslySkippedDep was querying map_index=-1 for every unmapped parent, finding no XCom, and letting all siblings proceed regardless of what the branch decided. Detect whether the parent ran in the same mapped context by checking for a finished parent TI at the child's map_index. If one exists, use that index for the XCom lookup; fall back to -1 only for truly unmapped parents (e.g. LatestOnlyOperator) that always write at -1.
Member
|
Closing this. #73959 fixed this on main: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a @task.branch lives inside a mapped @task_group it is not itself expanded (parent.is_mapped is False), but its TI runs at the group's map_index and SkipMixin writes the skip XCom there — not at -1. NotPreviouslySkippedDep was querying map_index=-1 for every unmapped parent, finding no XCom, and letting all siblings proceed regardless of what the branch decided.
Detect whether the parent ran in the same mapped context by checking for a finished parent TI at the child's map_index. If one exists, use that index for the XCom lookup; fall back to -1 only for truly unmapped parents (e.g. LatestOnlyOperator) that always write at -1.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.