Repository navigation
UI: Render Arabic durations with the correct dual/plural form - #72604
Merged
Merged
Conversation
Arabic inflects a counted noun four ways, but dayjs's `ar` locale stores a single template per unit, so every count above one took the 3-10 form: a two-hour deadline read "2 ساعات" where the dual "ساعتان" is required, and an eleven-day one read "11 أيام" instead of "11 يومًا". Locales with comparable plural systems -- Hebrew, Russian, Polish -- already pass a function instead of a template and render correctly at every count; Arabic was simply never migrated. This applies the same treatment locally until the fix can be made upstream. Two assertions from the previous change pinned the uninflected output and are updated here.
baha-bouali
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
September 6, 2026 22:10
Contributor
Author
bbovenzi
approved these changes
Oct 21, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 22, 2026
…72604) (#75323) * [v3-4-test] UI: Render Arabic durations with the correct plural form (#72604) Arabic inflects a counted noun four ways, but dayjs's `ar` locale stores a single template per unit, so every count above one took the 3-10 form: a two-hour deadline read "2 ساعات" where the dual "ساعتان" is required, and an eleven-day one read "11 أيام" instead of "11 يومًا". Locales with comparable plural systems -- Hebrew, Russian, Polish -- already pass a function instead of a template and render correctly at every count; Arabic was simply never migrated. This applies the same treatment locally until the fix can be made upstream. Two assertions from the previous change pinned the uninflected output and are updated here. (cherry picked from commit 8070289) Co-authored-by: Baha Bouali <baha.bouali2020@gmail.com> * UI: Drop Arabic plural test cases that no longer go through dayjs (#75330) (cherry picked from commit a3a4c13) --------- Co-authored-by: Baha Bouali <baha.bouali2020@gmail.com> Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arabic inflects a counted noun four ways, but dayjs's
arlocale stores asingle template per unit, so every count above one took the 3-10 form: a
two-hour deadline read "2 ساعات" where the dual is required, and an eleven-day
one read "11 أيام" instead of "11 يومًا".
The dual must also agree in case with whatever governs it, and it is the only
form that spells its case out rather than carrying it in an unwritten vowel.
Every humanized duration in this UI sits under a preposition -- خلال in the
deadline rule, and dayjs's own منذ / بعد around every relative time -- so the
oblique is the form these positions require.
Locales with comparable plural systems -- Hebrew, Russian, Polish -- already
pass a function instead of a template; Arabic was simply never migrated.
PR body
Arabic durations in the UI were both mis-pluralised and mis-inflected.
dayjs's
arlocale stores one template per unit ("%d ساعات"), so everycount above one rendered the 3–10 form: a two-hour deadline read "2 ساعات",
an eleven-day one "11 أيام". Arabic has four plural categories, and the
dual and 11–99 forms are different words.
The dual also has to agree in case with what governs it — and it is the
only form that spells its case out. Every humanized duration here sits
under a preposition (
خلالin the deadline rule, and dayjs's ownمنذ/بعدaround every relative time), so the obliqueساعتينis required,not the citation form
ساعتان.Hebrew, Russian and Polish already pass a function instead of a template;
Arabic was never migrated. This applies the same treatment locally.
Before (DUAL)
After (DUAL , with accusative form)
Before (Plural - some)
After (Plural - some)
After (Singular) : correct as before
Counts of 3 and above are checked against
Intl.DurationFormat, whichreads the same CLDR data, across every count in each unit's humanize
window. The dual is pinned explicitly, since Intl formats a standalone
duration and so returns the nominative.
Was generative AI tooling used to co-author this PR?