Skip to content

Remove unused FAB app-init helpers that could never run - #72610

Merged
vincbeck merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-fab-remove-unused-app-init-helpers
Sep 9, 2026
Merged

vincbeck merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-fab-remove-unused-app-init-helpers

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Remove three leftovers of the Airflow 2 Flask webserver from the FAB provider: init_appbuilder_views(), cached_app() / purge_cached_app(), and the two conftest entries that referenced init_appbuilder_views().

Why

Verification

  • uv run --project providers/fab pytest providers/fab/tests/unit/fab/www --with-db-init
  • uv run --project providers/fab pytest providers/fab/tests/unit/fab/auth_manager --with-db-init

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 marked this pull request as ready for review September 7, 2026 07:14

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that

@vincbeck
vincbeck merged commit 91657fe into apache:main Sep 9, 2026
152 checks passed
@FrankYang0529
FrankYang0529 deleted the airflow-fab-remove-unused-app-init-helpers branch September 9, 2026 13:27
imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants