Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove three leftovers of the Airflow 2 Flask webserver from the FAB provider:
init_appbuilder_views(),cached_app()/purge_cached_app(), and the two conftest entries that referencedinit_appbuilder_views().Why
init_appbuilder_views()has had no caller since Remove references of "airflow.www" in FAB provider #46914 copied it into the provider. The only view it registers,FabIndexView, is already added byAirflowAppBuilder._add_admin_views()(since Make FAB auth manager login process compatible with Airflow 3 UI #45765).cached_app()callscreate_app()without the requiredenable_pluginsargument, so it raisesTypeErroron first use, andpurge_cached_app()only ever cleared that always-empty cache. Airflow 3 mounts the Flask app object into FastAPI directly and has no use for a gunicorn-style cached factory.Verification
uv run --project providers/fab pytest providers/fab/tests/unit/fab/www --with-db-inituv run --project providers/fab pytest providers/fab/tests/unit/fab/auth_manager --with-db-initWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.