Repository navigation
Move retry policy decision outside post execute log group block - #73023
Merged
amoghrajesh merged 1 commit intoSep 15, 2026
Merged
Conversation
Member
|
2nd screenshot also still shows it in "post execute" |
Contributor
Author
|
@kaxil first and second screenshots were before the changes. Third is after |
Member
Oh I see it now! |
kaxil
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
What
When a retry policy is configured, the decision it makes ("retry" or "fail", and why) is only ever logged as a single
structlogline:"Retry policy decision". That line renders inside the::group::Post Executecollapsed section of the task log viewer, so a Dag author or a user viewing logs has to expand a collapsed group to see why their task did or didn't retry, which is the one place this information surfaces today.Current behaviour
_evaluate_retry_policylogs the decision unconditionally after thePost Executegroup is opened by the calling exception handler, so the log viewer hides it by default.Proposed change
Close the
Post Executegroup immediately before logging the retry decision, so the line renders visibly instead of nested inside a collapsed section. Nothing meaningful is logged between the retry decision and the end of the task run in any failure path (_finalize_task_failurelogs nothing, andrun()'s finally block only logs on rare supervisor-send failures), so the group is left closed rather than reopened.Testing
example_llm_retry_policyDAGBefore:
Now:
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.