Repository navigation
Fix the RAT licence check excludes and move it to Apache RAT 0.18 - #73064
Merged
Merged
Conversation
The exclude entry for these was written as a regex, .*\.iml, but RAT matches exclude patterns as globs against the full path. That form needs two dots to match, so airflow-core.iml and its 76 siblings never matched it and the check reported 77 unapproved licences for anyone who had opened the repo in IntelliJ. The files are gitignored and so never reach a source tarball, which is why the release-time check stayed green and the breakage only ever showed up locally. Use the same **/ form the rest of the file already uses for patterns that have to match at any depth. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q
The image reference has stayed on RAT 0.17 since 0.18 was adopted everywhere else, because the 0.18 image was never built: the release docs, the release validator and this script were all moved to 0.18, but no 0.18 tag was ever pushed, so the prek hook kept pulling the 0.17 image. Dating the image afresh gives the 0.18 build a tag of its own rather than overwriting a published one. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q
This was the one reference left behind when RAT 0.18 was adopted, so the check has been running 0.17 while the release docs and the release validator told everyone else to use 0.18. Point it at the freshly built 0.18 image, pinned by index digest as before so both architectures resolve. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496 and
jscheffl
as code owners
September 13, 2026 08:43
vatsrahul1001
approved these changes
Sep 13, 2026
1 task
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
…ache#73064) * Make the RAT licence check ignore IntelliJ module files again The exclude entry for these was written as a regex, .*\.iml, but RAT matches exclude patterns as globs against the full path. That form needs two dots to match, so airflow-core.iml and its 76 siblings never matched it and the check reported 77 unapproved licences for anyone who had opened the repo in IntelliJ. The files are gitignored and so never reach a source tarball, which is why the release-time check stayed green and the breakage only ever showed up locally. Use the same **/ form the rest of the file already uses for patterns that have to match at any depth. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q * Rebuild the Apache RAT image on RAT 0.18 The image reference has stayed on RAT 0.17 since 0.18 was adopted everywhere else, because the 0.18 image was never built: the release docs, the release validator and this script were all moved to 0.18, but no 0.18 tag was ever pushed, so the prek hook kept pulling the 0.17 image. Dating the image afresh gives the 0.18 build a tag of its own rather than overwriting a published one. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q * Run the licence check on Apache RAT 0.18 This was the one reference left behind when RAT 0.18 was adopted, so the check has been running 0.17 while the release docs and the release validator told everyone else to use 0.18. Point it at the freshly built 0.18 image, pinned by index digest as before so both architectures resolve. Generated-by: Claude Opus 5 Claude-Session: https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q --------- Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes to the Apache RAT licence check, all found while verifying the 2026-09-09 providers RC.
The
.imlexclude never matched. The entry was written as a regex,.*\.iml, but RAT matches exclude patterns as globs against the full path, and that form needs two dots. Soairflow-core.imland its 76 siblings were never excluded, and the check reported 77 unapproved licences for anyone who had opened the repo in IntelliJ. The files are gitignored and so never reach a source tarball, which is why the release-time check stayed green and the breakage only ever showed locally. Switched to**/*.iml, the form the rest of the file already uses for patterns that must match at any depth.The check was still on RAT 0.17. When 0.18 was adopted (#64231) the release docs, the release validator and
build_and_push.shall moved, butscripts/ci/prek/check_license.pywas missed — and no 0.18 image was ever pushed, so the hook kept pulling 0.17 while release managers were told to use 0.18. The image has now been built and pushed as0.18-2026.09.13, and the pin points at it by index digest, as before, so both architectures resolve.The image is dated afresh rather than reusing
2025.10.24, so the published 0.17 tag stays intact for anyone on an older commit.Verified: the hook passes on 0.18 (0 unapproved, 10458 standard files); deleting the local image first confirmed it pulls the pinned digest.
git grepshows no tracked file referencing 0.17 any more.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5 following the guidelines
🤖 Generated with Claude Code
https://claude.ai/code/session_012zrnHJHPchB83FtwrYRf5q