Repository navigation
Fix BaseXCom docstrings that say passing None removes a filter - #73066
Merged
henry3260 merged 1 commit intoSep 13, 2026
Merged
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
marked this pull request as ready for review
September 13, 2026 11:19
FrankYang0529
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
September 13, 2026 11:19
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
…e#73066) Signed-off-by: PoAn Yang <payang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
BaseXCom.get_one,aget_one,get_valueandaget_valuedocstrings say "Pass None (default) to remove the filter" forkey,dag_id,task_idandmap_index. The text comes from the Airflow 2BaseXCom, where these parameters were optional. AIP-72: Handle Custom XCom Backend on Task SDK #47339 moved the methods into the Task SDK and madekey,dag_idandtask_idrequiredstr, but kept the text. Add async XCom accessors for async tasks #68299 copied it into the async methods.How
key,dag_idandtask_idwithout theNonenote.map_index=Noneas pulling the XCom of a non-mapped task (map index-1).Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.