Skip to content

Add missing Amazon provider unit tests - #73169

Open
fat-catTW wants to merge 1 commit into
apache:mainfrom
fat-catTW:add-amazon-overlooked-tests
Open

fat-catTW wants to merge 1 commit into
apache:mainfrom
fat-catTW:add-amazon-overlooked-tests

Conversation

@fat-catTW

@fat-catTW fat-catTW commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add dedicated unit tests for several Amazon provider modules that were listed in OVERLOOKED_TESTS.

This covers:

  • AWS auth manager login response datamodel
  • AWS executor base config keys
  • AWS Lambda executor utils
  • AWS Batch executor config

The covered files are removed from OVERLOOKED_TESTS.

Note: After review, this PR now only adds tests for BaseConfigKeys iteration behavior and AWS Batch unsupported submit_job_kwargs validation.

Was generative AI tooling used to co-author this PR?
  • [X] Yes (please specify the tool below)

Generated-by: [Codex] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Sep 15, 2026
@fat-catTW
fat-catTW force-pushed the add-amazon-overlooked-tests branch from 3f08357 to e54f91c Compare September 15, 2026 16:42
Comment thread providers/amazon/tests/unit/amazon/aws/executors/aws_lambda/test_utils.py Outdated
Comment thread providers/amazon/tests/unit/amazon/aws/auth_manager/datamodels/test_login.py Outdated

@o-nikolas o-nikolas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that you had over 15 PRs submitted and this work seems pretty sloppy. I'm not going to close this yet, but do take these changes seriously. It takes a lot of our time to review these. Don't make changes like these just to say you had PRs merged into Apache Airflow.

Comment thread providers/amazon/tests/unit/amazon/aws/auth_manager/datamodels/test_login.py Outdated
Comment thread providers/amazon/tests/unit/amazon/aws/executors/aws_lambda/test_utils.py Outdated
@fat-catTW
fat-catTW force-pushed the add-amazon-overlooked-tests branch from 94588a6 to 9445abd Compare September 30, 2026 03:07
@fat-catTW

Copy link
Copy Markdown
Contributor Author

Thank you for the honest feedback, and I’m sorry for the extra review burden this caused.

I take the reviews seriously and really appreciate the time maintainers spend reviewing contributions.
For context, those PRs were opened over a longer period, from July to September, and most of them were closed recently because of the new policy limiting contributors to 5 open PRs.

I understand that quality matters more than quantity.

@fat-catTW

Copy link
Copy Markdown
Contributor Author

@o-nikolas
This PR has been open for a while. Could you take another look when you have a chance? Thanks a lot!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants