Repository navigation
Conversation
3f08357 to
e54f91c
Compare
e54f91c to
94588a6
Compare
o-nikolas
left a comment
There was a problem hiding this comment.
I saw that you had over 15 PRs submitted and this work seems pretty sloppy. I'm not going to close this yet, but do take these changes seriously. It takes a lot of our time to review these. Don't make changes like these just to say you had PRs merged into Apache Airflow.
94588a6 to
9445abd
Compare
|
Thank you for the honest feedback, and I’m sorry for the extra review burden this caused. I take the reviews seriously and really appreciate the time maintainers spend reviewing contributions. I understand that quality matters more than quantity. |
|
@o-nikolas |
Summary
Add dedicated unit tests for several Amazon provider modules that were listed in
OVERLOOKED_TESTS.This covers:
The covered files are removed from
OVERLOOKED_TESTS.Note: After review, this PR now only adds tests for
BaseConfigKeysiteration behavior and AWS Batch unsupportedsubmit_job_kwargsvalidation.Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.