Repository navigation
Add the resume event to stored next_kwargs without decoding them - #73576
Merged
potiuk merged 2 commits intoOct 19, 2026
Merged
Conversation
handle_event_submit only needs to add the trigger event to a task
instance's stored next_kwargs. It previously decoded the whole stored
payload, added the event and re-encoded everything, reconstructing every
stored value in the scheduler, triggerer and API server although only the
worker ever needs those objects.
Merge the serialized event into the stored serialized dict instead. Stored
values pass through untouched; payloads that are not a dict at the top
level still fail the task instance rather than resuming it. Rows still in
the legacy {"__type": "dict", "__var": ...} shape keep that shape.
Generated-by: Claude Opus 5
Member
Author
|
@ashb @amoghrajesh — gentle reminder: this needs a review to make the 3.4.0 cut on 2026-10-19. CI is green and it's ready from my side. |
4 tasks done
Member
Author
|
@uranusjr @amoghrajesh Could you take a look at this when you have a moment? It's targeted at 3.4.0 and needs a review to make the cut on 2026-10-19. CI is green. |
Generated-by: Claude Opus 5
vatsrahul1001
approved these changes
Oct 18, 2026
Contributor
There was a problem hiding this comment.
Looks good to me. Stored values are carried over encoded and the legacy form keeps its encoding. The worker already falls back to BaseSerialization.deserialize for legacy rows, and the tests check that nothing is constructed during event submission. Could use reviews from @uranusjr @amoghrajesh before merging.
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
added a commit
that referenced
this pull request
Oct 19, 2026
…ng them (#73576) (#75116) * Add the resume event to stored next_kwargs without decoding them handle_event_submit only needs to add the trigger event to a task instance's stored next_kwargs. It previously decoded the whole stored payload, added the event and re-encoded everything, reconstructing every stored value in the scheduler, triggerer and API server although only the worker ever needs those objects. Merge the serialized event into the stored serialized dict instead. Stored values pass through untouched; payloads that are not a dict at the top level still fail the task instance rather than resuming it. Rows still in the legacy {"__type": "dict", "__var": ...} shape keep that shape. Generated-by: Claude Opus 5 * Fail the task when a legacy resume event cannot be serialized (cherry picked from commit 1117472) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…ng them (#73576) (#75116) * Add the resume event to stored next_kwargs without decoding them handle_event_submit only needs to add the trigger event to a task instance's stored next_kwargs. It previously decoded the whole stored payload, added the event and re-encoded everything, reconstructing every stored value in the scheduler, triggerer and API server although only the worker ever needs those objects. Merge the serialized event into the stored serialized dict instead. Stored values pass through untouched; payloads that are not a dict at the top level still fail the task instance rather than resuming it. Rows still in the legacy {"__type": "dict", "__var": ...} shape keep that shape. Generated-by: Claude Opus 5 * Fail the task when a legacy resume event cannot be serialized (cherry picked from commit 1117472) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_event_submitonly needs to add the trigger event to a task instance's storednext_kwargs. It previously decoded the whole stored payload, added the event, andre-encoded everything — which reconstructs every stored value in the scheduler,
triggerer and API server, although only the worker ever needs those objects.
This merges the serialized event into the stored serialized dict instead. Stored values
pass through untouched (the worker deserializes them as before); payloads that are not
a dict at the top level still fail the task instance rather than resuming it. Rows still
in the legacy
{"__type": "dict", "__var": ...}shape keep that shape.Test plan:
object is never constructed during event submission
airflow-core/tests/unit/models/test_trigger.pypassesWas generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines at
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions