Skip to content

[v3-3-test] Add type-checking guards to DeadlineAlert init (#73294) - #73579

Closed
github-actions[bot] wants to merge 1 commit into
v3-3-testfrom
backport-b9e46d6-v3-3-test
Closed

github-actions[bot] wants to merge 1 commit into
v3-3-testfrom
backport-b9e46d6-v3-3-test

Conversation

@github-actions

Copy link
Copy Markdown
Contributor
  • Add type-checking guards to DeadlineAlert init
    (cherry picked from commit b9e46d6)

Co-authored-by: D. Ferruzzi ferruzzi@amazon.com

* Add type-checking guards to DeadlineAlert init
(cherry picked from commit b9e46d6)

Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
@potiuk
potiuk force-pushed the backport-b9e46d6-v3-3-test branch from 65b19a6 to a05f386 Compare September 28, 2026 10:34
@potiuk

potiuk commented Sep 28, 2026

Copy link
Copy Markdown
Member

@ferruzzi -> that one should not be cherry-picked right ?

@shahar1 shahar1 closed this Oct 2, 2026
@ferruzzi

ferruzzi commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@potiuk @shahar1 - Sorry, I was out sick for most of the week and just catching up. Yes, I think it should be backported and should travel with #73304, the two are tied together. #73304 added the decoder-side checks and this adds the same level of enforcement on the init-side. If this isn't backported, then init can accept values that the decoder won't accept.

@ferruzzi ferruzzi reopened this Oct 3, 2026
@shahar1

shahar1 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@potiuk @shahar1 - Sorry, I was out sick for most of the week and just catching up. Yes, I think it should be backported and should travel with #73304, the two are tied together. #73304 added the decoder-side checks and this adds the same level of enforcement on the init-side. If this isn't backported, then init can accept values that the decoder won't accept.

Hope you're doing better!
v3-3-test will be replaced soon by v3-4-test which will be cut from main, so no need to cherry pick anyway :)

@shahar1 shahar1 closed this Oct 3, 2026
@shahar1
shahar1 deleted the backport-b9e46d6-v3-3-test branch October 3, 2026 06:31
@ferruzzi

ferruzzi commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Hope you're doing better!
v3-3-test will be replaced soon by v3-4-test which will be cut from main, so no need to cherry pick anyway :)

My mistake then, sorry about that. Didn't intend to give you extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants