Repository navigation
Use POSIX-compliant tail to extract token line in EKS command - #73690
Merged
shahar1 merged 1 commit intoSep 27, 2026
Merged
Conversation
The bash parameter expansion with $'\n' quoting used to strip to the last line of the token helper output is a bash-specific extension not guaranteed by POSIX; it silently breaks on sh implementations that do not support it. Replace with `printf '%s\n' "$output" | tail -n 1`, which is portable and also handles spurious stdout lines from dependencies that bypass the stderr redirect.
AlejandroMorgante
force-pushed
the
fix-eks-token-last-line-posix
branch
from
September 24, 2026 20:07
a920053 to
5d66b41
Compare
1 task done
vincbeck
approved these changes
Sep 24, 2026
shahar1
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
COMMANDtemplate inEksHookused bash parameter expansion with$'\n'quoting to strip to the last line of the token helper output.$'...'is a bash extension — not POSIX — and silently breaks on someshimplementations used in container environments.Replace it with
printf '%s\n' "$output" | tail -n 1, which is POSIX-compliant and also tolerates extra lines on stdout when a dependency bypasses the stderr redirect.Split out from #72542 per review request, so the fix to the existing operator lands independently of the new operator.
related: #72542
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 4.6) following the guidelines