Repository navigation
Refuse nested secret ids looked up with no team in multi-team mode - #73789
Merged
Merged
Conversation
In multi-team mode with team-scoped paths, the Vault and Akeyless
secrets backends build a team's secret names under the same base path
that a lookup with no team resolves in. A connection or variable id
containing the path separator, looked up with no team, could therefore
name a team's secret: ``team1/db_password`` resolved
``{base_path}/team1/db_password``.
Refuse such ids for a caller with no team, the same way both backends
already refuse them for a caller with a team. Akeyless keeps resolving
them when ``global_secrets_path`` gives secrets used outside any team a
namespace of their own. The Amazon, Azure and Yandex backends already
refuse ids containing their team separator for every caller.
Generated-by: Claude Opus 5
potiuk
force-pushed
the
secrets-backend-global-scope-guard
branch
from
October 4, 2026 22:10
be47a72 to
00f8790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-team mode with team-scoped paths, the Vault and Akeyless secrets backends build a team's secret names under the same base path that a lookup with no team resolves in. A connection or variable id containing the path separator, looked up with no team, could therefore name a team's secret:
team1/db_passwordresolved{base_path}/team1/db_password.Such ids are now refused for a caller with no team, the same way both backends already refuse them for a caller with a team:
/, in multi-team mode withuse_team_secrets_pathenabled.global_secrets_pathis set, which gives secrets used outside any team a namespace of their own; nested ids keep working there.The Amazon, Azure and Yandex backends already refuse ids containing their team separator for every caller, so they need no change. Outside multi-team mode, or with
use_team_secrets_path=False, nothing changes. Both provider changelogs carry a note, since nested ids looked up with no team stop resolving in the affected configuration.🤖 Generated with Claude Code