Repository navigation
Support azure-datalake-store 1.x in AzureDataLakeHook - #73819
Merged
Merged
Conversation
aaron-y-chen
approved these changes
Sep 29, 2026
aaron-y-chen
left a comment
Contributor
There was a problem hiding this comment.
LGTM. It meets the requirements of the original issue and also prevents a breaking change.
eladkal
reviewed
Sep 30, 2026
eladkal
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azure-datalake-store 1.x removed
lib.auth, so the tenant path inAzureDataLakeHook.get_conn()fails. The managed identity path breaks too, since 1.x callsget_token()on the credential andAzureIdentityCredentialAdapterdoesn't have it.The hook now passes an azure-identity credential straight to
AzureDLFileSystem:ClientSecretCredentialwhen a tenant is set, the default Azure credential otherwise. Same approach asAzureDataLakeStorageV2Hook.Per review, the floor is now
azure-datalake-store>=1.0.1and the 0.0.x handling is gone. adlfs releases before 2026.5.0 pinazure-datalake-store<0.1, so adlfs is bumped to>=2026.5.0as well.Removed the
<1cap and the dependency floor exclusion.closes: #73795