Repository navigation
Fix Postgres data volume path in Breeze - #73862
Merged
Merged
Conversation
Andrushika
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
September 28, 2026 18:53
Andrushika
changed the title
Andrushika
marked this pull request as draft
September 28, 2026 18:53
ashb
reviewed
Sep 28, 2026
The postgres service mounted its named volume at
/var/lib/postgresql/{$POSTGRES_VERSION}/docker. The `$` sits inside the
braces, so the path resolves to a literal `{14}` directory that Postgres
never uses. The data went to an anonymous volume created from the
image's VOLUME instead, so `breeze down --preserve-volumes` did not keep
it, and each `down` without `--volumes` left anonymous volumes behind.
The image's VOLUME moved from /var/lib/postgresql/data to
/var/lib/postgresql in Postgres 18, so one static path cannot fit every
supported version.
Andrushika
force-pushed
the
pr-73836-ash-separate-change
branch
from
September 29, 2026 11:39
601beb6 to
16aeced
Compare
Andrushika
marked this pull request as ready for review
September 29, 2026 11:42
Commands that run without a database, such as `breeze testing task-sdk-tests`, build ShellParams with an empty postgres_version, and parsing it as a number failed before any test ran.
Contributor
|
Thanks for the fix! |
fat-catTW
approved these changes
Sep 29, 2026
ashb
approved these changes
Sep 29, 2026
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker a65a3dd v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Breeze mounts a named volume into the postgres container, so its data can survive
breeze down --preserve-volumes. The mount path inbackend-postgres.ymlis/var/lib/postgresql/{$POSTGRES_VERSION}/docker. The$sits inside the braces, so the path resolves to a literal{14}directory. Postgres never uses that directory.The data goes to an anonymous volume instead. It is lost on
down, and the anonymous volume is left behind.What
Mount the volume at the image's data volume path. Breeze now passes this path per version (
/var/lib/postgresql/dataup to 17,/var/lib/postgresqlfrom 18). #73836 made the volume name unique per project, so parallel test types still get their own data directory.related: #73836
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines