Repository navigation
Require common.sql 2.2.0 for common.ai's SQL extras - #73867
Merged
Merged
Conversation
The LLMSchemaCompareOperator guide and example now show a DataSourceConfig
holding only conn_id and table_name. That form needs common.sql 2.2.0; on
2.1.1 it raises "Unsupported storage type for URI". Raise the floor of the
sql and common.sql extras to match.
Also fix two docs issues found while testing 0.10.0rc1: comments in the
classifier example Dag that predate decision_policy and the decision XCom,
and a categories={...} placeholder in the retry policy guide that raised
TypeError when copied.
potiuk
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#73273 changed the
LLMSchemaCompareOperatorguide andexample_llm_schema_compare.pyto show aDataSourceConfigwith onlyconn_idandtable_name. That form is new in common.sql 2.2.0. On common.sql 2.1.1 it raisesValueError: Unsupported storage type for URI:, so the example Dag fails to import. Thesqlandcommon.sqlextras still allowed>=1.33.0, which lets a user upgrade common.ai on its own and keep 2.1.1. This raises both floors to>=2.2.0, the common.sql version in the current provider wave (#73658). Only the two extras change; common.ai's required dependencies stay as they are.Two docs fixes are included:
example_classifier_model.pysaidLLMBranchOperatorcannot act on the model's confidence and that no operator puts it on XCom. Both stopped being true withdecision_policyand thedecisionXCom in Add a decision policy so an LLM operator asks a person when the model is unsure #73368.ClassifierRetryPolicyhints example inretry_policies.rstpassedcategories={...}, a set literal that raisesTypeErrorwhen copied. The Snowflake table earlier on the page is now a namedSNOWFLAKE_CATEGORIES, and both examples use it.Needs the
allow provider dependency bumplabel.