Repository navigation
Return an approved agent answer as output_type after human review - #73904
Merged
kaxil merged 1 commit intoSep 29, 2026
Merged
Conversation
With enable_hitl_review, AgentOperator ran the approved text through json.loads unless output_type was a Pydantic model, so an answer of "42" came back as an int and one that looked like a JSON object as a dict, even with the default output_type=str. It now uses the same conversion as LLMOperator's approval path: str passes through unchanged, and any other output_type is validated from the JSON, falling back to the text a reviewer edited into something the type rejects.
vatsrahul1001
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
enable_hitl_review=True,AgentOperatorran the approved text throughjson.loadsunlessoutput_typewas a Pydantic model. So with the defaultoutput_type=str, an approved answer of42came back as an int, and one that looked like a JSON object came back as a dict.@task.llmreturns the same text unchanged.It now uses the same conversion as
LLMOperator's approval path: astroutput passes through unchanged, any otheroutput_typeis validated from the JSON, and an edit the type rejects falls back to the reviewer's text. The new test fails on the old code for the twostrcases.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.