Repository navigation
Retry S3Hook.delete_bucket when a late write leaves bucket non-empty - #73930
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
With force_delete, the retries only covered emptying the bucket. An object that lands after the final empty listing (for example a service still uploading logs) made DeleteBucket fail with BucketNotEmpty and nothing retried it.
seanghaeli
force-pushed
the
ghaeli/s3-delete-bucket-retry
branch
from
September 29, 2026 23:38
68cd7a4 to
7de86e7
Compare
seanghaeli
marked this pull request as ready for review
September 29, 2026 23:58
kaxil
approved these changes
Sep 30, 2026
vincbeck
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #31192:
S3Hook.delete_bucket(force_delete=True)retried emptying the bucket but calledDeleteBucketonly once afterwards, so an object written in between failed the delete withBucketNotEmpty. This includes theDeleteBucketcall in the existing retry loop, so aBucketNotEmptythere re-empties the bucket and tries again.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-fable-5) following the guidelines