Skip to content

Pr/split storage tab - #73989

Merged
bbovenzi merged 3 commits into
apache:mainfrom
astronomer:pr/split-storage-tab
Oct 5, 2026
Merged

bbovenzi merged 3 commits into
apache:mainfrom
astronomer:pr/split-storage-tab

Conversation

@bbovenzi

Copy link
Copy Markdown
Contributor

Hiding Xcom and Task Store under a single tab was a mistake. Let's just have them both on the top level.

Screenshot 2026-09-30 at 4 54 10 PM
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Claude Opus

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

XCom and the task state store were grouped behind one Storage tab because
both are key-value stores, which groups them by storage mechanism rather
than by what a user came to look at. Neither is a sub-view of the other.

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that static checks fail, other than that - LGTM

Splitting the Storage tab removed the only pathless layout route, so
`taskInstanceRoutes` no longer has an entry with `children`. That left the
`"children" in route` branch unreachable, and with nothing in the union to
type it `route.children` degraded to `any`, failing the UI lint with four
`no-unsafe-*` errors.

Co-Authored-By: Claude <noreply@anthropic.com>
@bbovenzi
bbovenzi merged commit f577478 into apache:main Oct 5, 2026
88 of 90 checks passed
@bbovenzi
bbovenzi deleted the pr/split-storage-tab branch October 5, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants