Repository navigation
Fix Non-DB test collection failure in Google Stackdriver hook test - #74066
Merged
shahar1 merged 1 commit intoOct 2, 2026
Merged
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
marked this pull request as ready for review
October 2, 2026 05:25
shahar1
approved these changes
Oct 2, 2026
Lee-W
approved these changes
Oct 2, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI in #68625 failed with following message:
https://github.com/apache/airflow/actions/runs/36953939813/job/110675454131?pr=68625
Why
test_stackdriver.pypassesConnection(conn_id="google_cloud_default")as thereturn_valueof amock.patchdecorator. That expression runs when pytest imports the module during collection. Creating the ORM object makes SQLAlchemy configure every mapper that is registered at that moment.apache.kafka,common.compat,common.messagingandgoogletests. The kafka asset tests import theairflow.models.assetmodule throughcommon.compat. That module definesAssetWatcherModel, which has a relationship toTrigger. No test module has importedairflow.models.triggeryet whentest_stackdriver.pyis collected.How
mock.MagicMock(spec=Connection).Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.