Repository navigation
[v3-3-test] Skip already-released providers in update-providers-next-version (#74098) - #74121
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…version (#74098) The command resolved every "# use next version" pin to the referenced provider's current version and dropped the marker, without checking whether that version is the one being released. That is only right while the version is still unreleased in the same release PR. In an ad-hoc release that does not include the referenced provider, the pin ended up at a floor that lacks the required code, and the marker was lost so later waves never corrected it. A final release tag now leaves the pin untouched. Release candidate tags alone are ambiguous (in vote, or re-cut in this release), so the pin is still resolved there, with a warning for the release manager. (cherry picked from commit 66d751b) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command resolved every "# use next version" pin to the referenced
provider's current version and dropped the marker, without checking
whether that version is the one being released. That is only right while
the version is still unreleased in the same release PR. In an ad-hoc
release that does not include the referenced provider, the pin ended up
at a floor that lacks the required code, and the marker was lost so later
waves never corrected it.
A final release tag now leaves the pin untouched. Release candidate tags
alone are ambiguous (in vote, or re-cut in this release), so the pin is
still resolved there, with a warning for the release manager.
(cherry picked from commit 66d751b)
Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com