Repository navigation
Go SDK: delete the XComs of earlier tries before a task runs - #74178
Merged
jason810496 merged 2 commits intoOct 5, 2026
Merged
jason810496 merged 2 commits into
jason810496 merged 2 commits into
Conversation
1 task done
FrankYang0529
marked this pull request as ready for review
October 4, 2026 08:19
FrankYang0529
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 4, 2026 08:19
jason810496
reviewed
Oct 5, 2026
jason810496
left a comment
Member
There was a problem hiding this comment.
IIRC, the TS and Java SDK runtime didn't respect the xcom_keys_to_clear as well.
Please feel free to raise follow-up PRs for them as well, thanks.
This was referenced Oct 5, 2026
Member
Author
Thanks for the review. Created two follow-up PRs: |
jason810496
approved these changes
Oct 5, 2026
jason810496
left a comment
Member
There was a problem hiding this comment.
Nice, thanks. Except the reusability comment, rest of the change LGTM.
Signed-off-by: PoAn Yang <payang@apache.org>
…XCom Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-go-sdk-clear-earlier-try-xcoms
branch
from
October 5, 2026 10:29
411d274 to
e8ac4e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #74075 (comment).
When a task instance starts a new try, Airflow keeps the XComs it already has and lists their keys in
ti_context.xcom_keys_to_clearfor the runtime to delete. The Python task runner deletes them before it renders templates. The Go runtime never read the field, so a retried Go task still saw the XComs of its previous try. With this change the Go runtime deletes them too, and the retried task no longer sees them.RunTasksends aDeleteXComfor each key after it finds the task and before it binds arguments or runs the task.RetryTaskwhenshould_retryis set and with a FAILEDTaskStateotherwise.dag.Ifno longer writes{"skipped": []}toskipmixin_keybefore the condition runs, since the delete now removes the list from an earlier try.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.