Repository navigation
Conversation
Worker hooks were rebuilt from ssh_conn_id alone, so constructor overrides such as remote_host, port, credentials and proxy were dropped and a directory listed through an explicit remote_host was transferred from the connection's host instead. closes: apache#74208 Generated-by: Claude Opus 5
4 tasks done
Contributor
|
Looks like #73647 (already merged) fixes this exactly! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFTPHook.retrieve_directory_concurrently()andstore_directory_concurrently()rebuilt each worker hook fromssh_conn_idalone. Anything the caller passed to the hook's constructor —remote_host, port, username, password / key file, proxy command, host key settings — was dropped, so the workers connected with the connection's defaults. A directory listed through an explicitremote_hostcould then be transferred from the connection's original host.The workers are now copies of the parent hook with only the connection state reset (
conn,client, the managed-connection counters and the cachedhost_proxy), so each worker still opens its own connection and proxy but uses the parent's effective settings.Tests: a regression test checks that a worker hook keeps the parent's constructor overrides and connection-derived host key setting while starting with no open connection, and a parametrized test checks that both concurrent transfer paths build their workers through it.
closes: #74208
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines