Skip to content

Correct usage_limits=None docstring on AgentOperator and LLMOperator - #74307

Merged
shahar1 merged 1 commit into
apache:mainfrom
astronomer:usage-limits-none-docstring
Oct 6, 2026
Merged

shahar1 merged 1 commit into
apache:mainfrom
astronomer:usage-limits-none-docstring

Conversation

@kaxil

@kaxil kaxil commented Oct 5, 2026

Copy link
Copy Markdown
Member

The usage_limits docstrings on AgentOperator and LLMOperator say None (the default) "means no enforcement". That is wrong: pydantic-ai replaces None with UsageLimits() (usage_limits = usage_limits or UsageLimits() in Agent.iter), so its default request_limit=50 still applies and a long tool loop fails with UsageLimitExceeded at 50 requests. That is the failure the run captured in #74297 hit with usage_limits unset.

The docstrings now say None sets no token, cost, or tool-call limits but keeps the 50-request cap. The LLMOperator docstring also drops the sentence implying that moving from None to a cost_limit-only dict newly introduces the cap. Both already have it. The LLM* operators that inherit usage_limits from LLMOperator pick up the fix, and the how-to pages already describe the default correctly.

Checked against pydantic-ai-slim 2.33.0 (the provider's floor) and 2.48.0: a FunctionModel that always calls a tool raises UsageLimitExceeded: The next request would exceed the request_limit of 50 with usage_limits=None, and UsageLimits(request_limit=None) runs past 50 requests.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

usage_limits=None does not disable limits: pydantic-ai substitutes
UsageLimits() for None, so its default request_limit=50 still applies.
@shahar1
shahar1 merged commit 31b7748 into apache:main Oct 6, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants