Repository navigation
Add an e2e test for the Java SDK task state store - #74403
Open
Andrushika wants to merge 1 commit into
Open
Andrushika wants to merge 1 commit into
Andrushika wants to merge 1 commit into
Conversation
The Java SDK task state store had unit tests only. Nothing checked that a real Java task reaches the database through the supervisor, or that the coordinator passes [state_store] default_retention_days to the JVM. The Go SDK already has an e2e test for both.
Andrushika
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
October 7, 2026 11:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#73464 added the task state store to the Java SDK with unit tests only. The Go SDK has an e2e test for the same API (
go_sdk_tests/test_go_sdk_task_state.py). It runs a real task, reads the keys back through the REST API, and checks that[state_store] default_retention_daysreaches the task process. Nothing checks this for Java yet, including that the coordinator passes the setting to the JVM.What
Add a
RoundtripTaskStatetask tojava-test-bundleand aTestJavaSDKTaskStateStoreclass that follows the Go test. Java and Go modes now write the retention config through one helper, so the constant is renamed toLANG_SDK_STATE_STORE_RETENTION_DAYS. The retention test fails when the Java mode does not write the config (30 days instead of 7), and every test fails when the Java task throws before writing.related: #73464, #73420
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines