Repository navigation
Speed up Migration 0136 on MySQL - #74409
Merged
Merged
Conversation
kaxil
reviewed
Oct 7, 2026
kaxil
approved these changes
Oct 7, 2026
kaxil
left a comment
kaxil
left a comment
Member
There was a problem hiding this comment.
LGTM. The inline comments are optional; happy either way on dropping the CHECK entirely.
ashb
force-pushed
the
xcom-mapped-length-check-not-valid
branch
from
October 7, 2026 21:14
56a8bee to
ce7ee77
Compare
eladkal
approved these changes
Oct 8, 2026
When migration 0136 was written and merged, xcom was still being written to, but now that 0142 has landed this table is read-only. So it makes no sense to spend any time writing this migration. (It turns out that adding a CHECK constraint on mysql _copies the entire table_. Large values and all.)
ashb
force-pushed
the
xcom-mapped-length-check-not-valid
branch
from
October 8, 2026 08:40
ce7ee77 to
875f7b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that adding a CHECK constraint on mysql copies the entire
table. Large values and all.
Enforcing this check is simply not worth a possibly 4 hour migration!
Doubly so now that 0142 has landed, and nothing live will write any new row to this table.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.