Repository navigation
Fix plugin applies_to scoping - #74425
Merged
Merged
Conversation
bbovenzi
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
gopidesupavan,
guan404ming,
jason810496,
jscheffl,
pierrejeambrun,
potiuk,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 7, 2026 20:53
boring-cyborg
Bot
added
area:dev-tools
area:plugins
area:UI
Contributor
Author
Several things shipped with the field-path scoping in apache#74278 that review caught after it merged, plus two fixes that depend on work landing since. The troubleshooting steps name `airflow plugins list`, which does not exist -- `plugins` takes no subcommand -- so anyone following them to find out why a view is not scoped as expected gets an argparse error instead. The operator section recommends leaving `operator` and `class_ref.class_name` unqualified so each page reads its own record, which is right, but the load-time check then reports the one the page lacks as a path that will make the view "appear in more places than intended". That is untrue for this block: the other path is what scopes this destination. Following the documentation should not produce a warning saying the documentation is wrong. The check now tells a path that names no field anywhere -- a misspelling -- apart from one that names a real field on a record this destination does not have, and says only what is true of each. The section leads with one view per destination, which needs no such reasoning, and keeps the single block as the shorter form. A path that matches no field at all now withholds the view instead of loading it. The browser cannot tell a misspelling from a field this page's record simply does not have -- a block shared across destinations relies on the latter being skipped -- so it skips both, and skipping widens the scope. A typo therefore showed the view everywhere, the opposite of what its author asked for. The response models are in hand when plugins load, so the two are distinguishable there: a field no record has cannot be anything but a mistake, while one a sibling record has is the shared-block pattern and still loads. A view that disappears gets noticed; one on every page looks deliberate. Validation also edited the plugin author's own `applies_to` dictionary to drop null values. Harmless in isolation, but a plugin may pass one dictionary to several views, and rewriting it is not this code's to do. Which record an unqualified path is rooted at is also decided twice: once when plugins load, to choose what to validate, and again in the browser, to choose what to match. Nothing at runtime notices when the two tables disagree -- a destination only one of them knows about makes every path on it unevaluable, which shows the view everywhere instead of scoping it, and would surface later as someone else's bug. A prek check compares them, so that drift fails before it merges. Scoping a task-level view on `task.*` judged historical task instances by the Dag's definition today, so a view scoped to an operator stopped appearing on the runs that actually used it as soon as the task changed. apache#74365 added a version to the task endpoint, so the task is now read at the version the instance ran. That costs a round trip on task instance routes, since the version is not known until the instance arrives, and asking earlier would fetch a task that has to be discarded. The newsfragment was a documentation section rather than a release note, so it is cut to what the release notes need and points at the docs for the rest. Editing it trips `check-newsfragment-pr-number`, which expects any newsfragment a PR touches to be named for that PR; renaming this one would credit the wrong PR for the feature, so the check is skipped by label instead.
bbovenzi
force-pushed
the
pr/plugins-applies-to-followups
branch
from
October 8, 2026 15:40
0df0d80 to
7e534a1
Compare
dheerajturaga
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merged #74278 but forgot I had some local commits that weren't pushed.
Drop invalid "list" command in
airflow plugins listA typo now hides the plugin instead of showing it everywhere.
Validation edited the plugin author's own
applies_todictionary to drop null values.Added guard to make sure that destinations in the plugin manager and the UI don't drift
Use #74365 to fetch the task level data for a task instance based on its version. Its an added API roundtrip but avoids task vs task instance mismatches.
Clena up the old newsfragment
Was generative AI tooling used to co-author this PR?
Claude Opus 5
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.