Skip to content

Show serializer schema in Dag version diff only when it differs - #74683

Merged
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:version-diff-schema-only-when-changed
Oct 14, 2026
Merged

jedcunningham merged 1 commit into
apache:mainfrom
astronomer:version-diff-schema-only-when-changed

Conversation

@jedcunningham

Copy link
Copy Markdown
Member

The Dag version comparison header always appended the serializer schema versions to the change count, e.g. "15 changes · serialized schema 3 → 3". When both versions share a schema (the usual case) this is noise.

The summary now shows only the change count. A " · Serialized schema X → Y" suffix is added only when the two versions were stored by different serializer schemas.

  • VersionDiff.tsx: render the count, and the schema suffix only when serializer_versions.base !== serializer_versions.target.
  • en/dag.json: summary_* carries only the count; new schemaChange key for the suffix.
  • Other locales (ca, de, el, fr, ko, pl, zh-TW): dropped the schema part from existing summary_* strings; schemaChange falls back to English until translated.
  • Tests: singular summary expects exactly "1 change"; new tests cover the schema hidden when equal and shown when different.

Before:

Screenshot 2026-10-13 at 8 20 39 PM

After:
Screenshot 2026-10-13 at 8 20 26 PM

The comparison summary always appended the serializer schema versions,
e.g. "15 changes · serialized schema 3 → 3", which is noise when both
versions share a schema.

Show only the change count, and append the schema transition only when
the base and target versions were stored by different serializer
schemas. Drop the schema part from the existing translated summaries and
add an English schemaChange string for the suffix.
@jedcunningham
jedcunningham merged commit c192bda into apache:main Oct 14, 2026
91 checks passed
@jedcunningham
jedcunningham deleted the version-diff-schema-only-when-changed branch October 14, 2026 04:56
@jedcunningham jedcunningham added this to the Airflow 3.4.0 milestone Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

bbovenzi pushed a commit that referenced this pull request Oct 14, 2026
…iffers (#74683) (#74739)

The comparison summary always appended the serializer schema versions,
e.g. "15 changes · serialized schema 3 → 3", which is noise when both
versions share a schema.

Show only the change count, and append the schema transition only when
the base and target versions were stored by different serializer
schemas. Drop the schema part from the existing translated summaries and
add an English schemaChange string for the suffix.
(cherry picked from commit c192bda)

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 20, 2026
…iffers (#74683) (#74739)

The comparison summary always appended the serializer schema versions,
e.g. "15 changes · serialized schema 3 → 3", which is noise when both
versions share a schema.

Show only the change count, and append the schema transition only when
the base and target versions were stored by different serializer
schemas. Drop the schema part from the existing translated summaries and
add an English schemaChange string for the suffix.
(cherry picked from commit c192bda)

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants