Repository navigation
Show Dag version diff values-hidden pill only when values are hidden - #74746
Merged
jedcunningham merged 1 commit intoOct 14, 2026
Merged
Conversation
The comparison header always showed an "Observed state" pill, a "Values shown"/"Values hidden" pill and a "Values require access to Dag code" hint, so users who could see values were still told they needed access. Drop the static "Observed state" and "Values shown" pills and show the "Values hidden" pill only when values are withheld, with the access hint as its hover tooltip. Remove the now-unused translation keys.
jedcunningham
requested review from
Lee-W,
ashb,
bbovenzi,
bugraoz93,
choo121600,
guan404ming,
henry3260,
jason810496,
jscheffl,
mobuchowski,
pierrejeambrun,
potiuk,
ryanahamilton and
vincbeck
as code owners
October 14, 2026 15:50
boring-cyborg
Bot
added
area:UI
kaxil
approved these changes
Oct 14, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 18, 2026
… are hidden (#74746) (#74960) The comparison header always showed an "Observed state" pill, a "Values shown"/"Values hidden" pill and a "Values require access to Dag code" hint, so users who could see values were still told they needed access. Drop the static "Observed state" and "Values shown" pills and show the "Values hidden" pill only when values are withheld, with the access hint as its hover tooltip. Remove the now-unused translation keys. (cherry picked from commit 27433bf) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
… are hidden (#74746) (#74960) The comparison header always showed an "Observed state" pill, a "Values shown"/"Values hidden" pill and a "Values require access to Dag code" hint, so users who could see values were still told they needed access. Drop the static "Observed state" and "Values shown" pills and show the "Values hidden" pill only when values are withheld, with the access hint as its hover tooltip. Remove the now-unused translation keys. (cherry picked from commit 27433bf) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidies the disclosure pills in the Dag version comparison header (Versions tab):
Checked manually with the FAB auth manager: an Admin user sees values and no pill; a user with Viewer permissions minus "can read on DAG Code" gets the redacted diff and the "Values hidden" pill with its tooltip.
Values visible, before:
Values visible, after:
Values hidden (user without DAG Code read), after, hovering the pill. Before, this showed "Observed state" + "Values hidden" + the hint inline: