Repository navigation
UI: Drop the loading spinner for base React plugins - #74762
Merged
Merged
Conversation
bbovenzi
approved these changes
Oct 14, 2026
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
Let's just fix the react tests and lgtm
Contributor
|
For your questions the latter sounds interested if its possible. Of course not every "base" plugin attaches to the top of the page so "remembering" the offset seems too specific and doesn't solve other possible loading issues |
A plugin with destination "base" renders above the content of every page. While its bundle loads, ReactPlugin's Suspense fallback put a bare spinner in the top left corner, so every full page load showed a stray spinner until the bundle arrived. Base plugins now render nothing until they are ready. Plugins on other destinations keep the spinner, since they fill a page or tab that would otherwise be empty.
jlaneve
force-pushed
the
react-plugin-base-fallback
branch
from
October 15, 2026 01:07
cc76607 to
af4f70f
Compare
jlaneve
marked this pull request as ready for review
October 15, 2026 01:42
jlaneve
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 15, 2026 01:42
1 task done
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 18, 2026
…) (#74964) A plugin with destination "base" renders above the content of every page. While its bundle loads, ReactPlugin's Suspense fallback put a bare spinner in the top left corner, so every full page load showed a stray spinner until the bundle arrived. Base plugins now render nothing until they are ready. Plugins on other destinations keep the spinner, since they fill a page or tab that would otherwise be empty. (cherry picked from commit 6cf8332) Co-authored-by: Julian LaNeve <lanevejulian@gmail.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…) (#74964) A plugin with destination "base" renders above the content of every page. While its bundle loads, ReactPlugin's Suspense fallback put a bare spinner in the top left corner, so every full page load showed a stray spinner until the bundle arrived. Base plugins now render nothing until they are ready. Plugins on other destinations keep the spinner, since they fill a page or tab that would otherwise be empty. (cherry picked from commit 6cf8332) Co-authored-by: Julian LaNeve <lanevejulian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A React plugin with
destination: "base"renders above the content of every page, and while its bundle loads,ReactPlugin's Suspense fallback puts a bare spinner in the top left corner. The page itself has already rendered by then, so every full page load shows a stray spinner above it until the plugin's bundle arrives. On a slow connection that can take seconds. Base plugins now render nothing until they are ready. Every other destination keeps the spinner, because there the plugin fills a page or tab that would otherwise be empty.Call-stack diff
BaseLayout └─ ReactPlugin({ reactApp }) # one per destination "base" app ├─ globalThis[reactApp.name] set? # unchanged: render it directly └─ <Suspense fallback> - ├─ <Spinner /> # every destination + ├─ null # destination "base" + ├─ <Spinner /> # every other destination └─ LazyPlugin -> loadPlugin(reactApp)localStorageand reserve it while the bundle loads, or have the server add amodulepreloadlink for base bundles toindex.htmlso they download alongside the UI. Happy to follow up with either if it sounds right.ReactPlugin.test.tsxcover both fallbacks. The base case fails if its fallback goes back to<Spinner />.Before and after, with the base plugin's bundle still loading (Airflow 3.3.1):
Before: a spinner sits in the top left above the page.
After: nothing shows until the plugin is ready.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5.5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.