Repository navigation
Match camelCase keys against sensitive field names in masker - #74840
Merged
Merged
Conversation
should_hide_value_for_key() only lowercased the key and replaced non-word runs with "_", so camelCase keys such as privateKey, connectionString or webhookUrl never matched multi-word entries like private_key. Keys are now also split on camelCase/PascalCase word boundaries (including acronym runs such as APIKey) before matching. Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
Member
Author
|
@amoghrajesh Could you take a look when you have a moment? It's targeted at 3.4.0 and needs a review to make the cut on 2026-10-19. |
vatsrahul1001
approved these changes
Oct 16, 2026
Generated-by: Claude Opus 5
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 16, 2026
…ker (apache#74840) * Match camelCase keys against sensitive field names in masker should_hide_value_for_key() only lowercased the key and replaced non-word runs with "_", so camelCase keys such as privateKey, connectionString or webhookUrl never matched multi-word entries like private_key. Keys are now also split on camelCase/PascalCase word boundaries (including acronym runs such as APIKey) before matching. Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Rename newsfragment to the PR number Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Pin prefix, digit and nested redact cases for camelCase key masking (cherry picked from commit 20ccfcd) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Generated-by: Claude Opus 5
potiuk
added a commit
that referenced
this pull request
Oct 17, 2026
…ker (#74840) (#74897) * Match camelCase keys against sensitive field names in masker should_hide_value_for_key() only lowercased the key and replaced non-word runs with "_", so camelCase keys such as privateKey, connectionString or webhookUrl never matched multi-word entries like private_key. Keys are now also split on camelCase/PascalCase word boundaries (including acronym runs such as APIKey) before matching. Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Rename newsfragment to the PR number Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Pin prefix, digit and nested redact cases for camelCase key masking (cherry picked from commit 20ccfcd) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task done
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…ker (#74840) (#74897) * Match camelCase keys against sensitive field names in masker should_hide_value_for_key() only lowercased the key and replaced non-word runs with "_", so camelCase keys such as privateKey, connectionString or webhookUrl never matched multi-word entries like private_key. Keys are now also split on camelCase/PascalCase word boundaries (including acronym runs such as APIKey) before matching. Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Rename newsfragment to the PR number Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Pin prefix, digit and nested redact cases for camelCase key masking (cherry picked from commit 20ccfcd) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task done
SameerMesiah97
pushed a commit
to SameerMesiah97/airflow-oss-sm97
that referenced
this pull request
Oct 27, 2026
…74840) * Match camelCase keys against sensitive field names in masker should_hide_value_for_key() only lowercased the key and replaced non-word runs with "_", so camelCase keys such as privateKey, connectionString or webhookUrl never matched multi-word entries like private_key. Keys are now also split on camelCase/PascalCase word boundaries (including acronym runs such as APIKey) before matching. Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Rename newsfragment to the PR number Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions * Pin prefix, digit and nested redact cases for camelCase key masking Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should_hide_value_for_key()normalised a key by lowercasing it and replacing non-word characters with_, then did a substring match against the sensitive field names. That works for snake_case, kebab-case and dotted keys, but camelCase / PascalCase keys lose their word boundaries:privateKey,connectionString,webhookUrl,accessKey,authHeader,keyfileDict,serviceAccountandserviceKeynever matchedprivate_key,connection_string,webhook_urland so on, so their values were not redacted (e.g. in connection extras, rendered fields or CLI output).The key is now additionally split on camelCase / PascalCase boundaries before lowercasing (
privateKey->private_key,APIKey->api_key,webhookURL->webhook_url). Matching is done against both the previous normalised form and the split form, so existing behaviour is unchanged — including user-configured names without separators (e.g.mysensitivekeystill matchesmySensitiveKey). The change lives in the sharedsecrets_maskerlibrary, which is the single implementation used by airflow-core and the Task SDK.Tests: extended
TestShouldHideValueForKeywith camelCase / PascalCase / acronym cases for the default field list, negative cases (primaryKey,connectionTimeout,serviceName), and configured-field cases; updated the comment from #66673 that noted camelCase was not covered.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5 following the guidelines