Repository navigation
[v3-4-test] Stop the secrets backend lookup from importing the task runner outside tasks (#74641) - #74980
Merged
Conversation
…unner outside tasks (#74641) ensure_secrets_backend_loaded() imported task_runner to check whether SUPERVISOR_COMMS was set. Outside a task, that loaded the task runtime just to learn the answer was no. Read the module from sys.modules instead, as mask_secret already does. That import also loaded the task runner in the supervisor before it forked the task process, and before callback processes when remote logging has a connection, so those children inherited it. Import it explicitly before a bare fork of a task or callback process instead, so each child does not import it again. If the import fails there, the child imports it again and reports the error in its own log, as before. (cherry picked from commit f46a370) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…unner outside tasks (#74641) (#74980) ensure_secrets_backend_loaded() imported task_runner to check whether SUPERVISOR_COMMS was set. Outside a task, that loaded the task runtime just to learn the answer was no. Read the module from sys.modules instead, as mask_secret already does. That import also loaded the task runner in the supervisor before it forked the task process, and before callback processes when remote logging has a connection, so those children inherited it. Import it explicitly before a bare fork of a task or callback process instead, so each child does not import it again. If the import fails there, the child imports it again and reports the error in its own log, as before. (cherry picked from commit f46a370) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure_secrets_backend_loaded() imported task_runner to check whether
SUPERVISOR_COMMS was set. Outside a task, that loaded the task runtime
just to learn the answer was no. Read the module from sys.modules
instead, as mask_secret already does.
That import also loaded the task runner in the supervisor before it
forked the task process, and before callback processes when remote
logging has a connection, so those children inherited it. Import it
explicitly before a bare fork of a task or callback process instead, so
each child does not import it again. If the import fails there, the
child imports it again and reports the error in its own log, as before.
(cherry picked from commit f46a370)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com