Repository navigation
UI: Add regression tests for Dags list rows remounting on refresh - #75005
Merged
bbovenzi merged 2 commits intoOct 20, 2026
Merged
Conversation
yuseok89
marked this pull request as ready for review
October 18, 2026 16:55
yuseok89
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 18, 2026 16:55
Contributor
|
Looks good. Let's just rebase |
yuseok89
force-pushed
the
ui-dags-list-remount-regression-tests
branch
from
October 20, 2026 09:35
5eda281 to
1da1f96
Compare
bbovenzi
approved these changes
Oct 20, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#69619 made the Dags list remount every row whenever the list auto-refreshed with active runs, since the cell renderers were recreated together with the run state counts. Besides the flicker fixed in #74426, I found that the remount also closed the dialog opened from the pause toggle at the next refresh, so it could close before the user chose between pausing and draining. #74426 fixed both by moving the renderers to module level.
This adds tests to keep the regression from coming back. They render the Dags list with a running Dag, let it auto-refresh with changing run state counts, and check both symptoms in the card and table views.
Each test fails on the code before #74426 and passes on main. The tests lower
auto_refresh_intervalto one second, so each one takes about 1.2s.related: #69619, #74426
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.