Skip to content

UI: Add regression tests for Dags list rows remounting on refresh - #75005

Merged
bbovenzi merged 2 commits into
apache:mainfrom
yuseok89:ui-dags-list-remount-regression-tests
Oct 20, 2026
Merged

bbovenzi merged 2 commits into
apache:mainfrom
yuseok89:ui-dags-list-remount-regression-tests

Conversation

@yuseok89

@yuseok89 yuseok89 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

#69619 made the Dags list remount every row whenever the list auto-refreshed with active runs, since the cell renderers were recreated together with the run state counts. Besides the flicker fixed in #74426, I found that the remount also closed the dialog opened from the pause toggle at the next refresh, so it could close before the user chose between pausing and draining. #74426 fixed both by moving the renderers to module level.

This adds tests to keep the regression from coming back. They render the Dags list with a running Dag, let it auto-refresh with changing run state counts, and check both symptoms in the card and table views.

  • The rows are not remounted after a refresh.
  • The pause or drain dialog opened from the toggle stays open across a refresh.

Each test fails on the code before #74426 and passes on main. The tests lower auto_refresh_interval to one second, so each one takes about 1.2s.

related: #69619, #74426


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    • Claude Code (Opus 5.5)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 18, 2026
@yuseok89
yuseok89 marked this pull request as ready for review October 18, 2026 16:55
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good. Let's just rebase

@yuseok89
yuseok89 force-pushed the ui-dags-list-remount-regression-tests branch from 5eda281 to 1da1f96 Compare October 20, 2026 09:35
@bbovenzi bbovenzi added the backport-to-v3-4-test Backport to v3-4-test label Oct 20, 2026
@bbovenzi bbovenzi added this to the Airflow 3.4.0 milestone Oct 20, 2026
@bbovenzi
bbovenzi merged commit 57ed6e7 into apache:main Oct 20, 2026
78 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

vatsrahul1001 pushed a commit that referenced this pull request Oct 21, 2026
… refresh (#75005) (#75252)

* UI: Add regression tests for Dags list rows remounting on refresh

* Drop the unused page_size from the Dags list refresh test config
(cherry picked from commit 57ed6e7)

Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-4-test Backport to v3-4-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants